-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F# migrate to v1.0.0-preview #354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -88,15 +87,15 @@ After the model is trained, you can use the `Predict()` API to predict whether n | |||
let classify = classifyWithThreshold 0.15f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevmal We don't need to use threshold value. The model predicts correctly if you follow the pipeline at https://github.com/dotnet/machinelearning-samples/blob/master/samples/csharp/getting-started/BinaryClassification_SpamDetection/SpamDetectionConsoleApp/Program.cs
CESARDELATORRE
pushed a commit
that referenced
this pull request
May 4, 2019
* removed unused assembly reference * Power anomaly consistency (#356) * Consistent MLModels folder * Consistent datastructures * Iris MultiClass Classification map scores with labels (#363) * Added code to classify github issues into the best 3 labels. 1.Created a class to hold Prediction values 2.Added Score filed in GitHubIssuePrediction class. 3.Changed the existing code in Labeler class. 4.Added new method to find the best 3 scores and return their indexes so that we can get the labels of those matched indexes from slotnames. * Changed the images * Changed Names * changed names * Removed images * Added images * removed seed parameter during prediction * WIP: pushed sample for object detection * Removing object detection solution from master branch * Added a new sample i.e Scalable WEBAPI for Real time scenario in the repo. so added link for that sample in ReadME file in seperate table. * Added code to retrieve labels from scores. Added comments how the scores are mapped to labels. * updated ReadMe file according to upstream master * Removed duplicate images folder and ReadMe-1.0.0-preview.md file(will add this in other branch) * Updated ReadMe file of IRIS and Mnist. Removed comment in MNIST * Minor changes in ReadMe file * Minor change in comment * Parse float from string with invariant culture (#357) * Use culture when parsing * Cosmetic change to align folder naming inside the C# solution * Use InvariantCulture when parsing a string to a float. * [Issue 345] Fix after PR Review * [#345] Remove useless using * Restructured Heart Disease sample and added the heart disease dataset in datasets.md file * Update README.md * Update DATASETS.md * Update README.md * F# migrate to v1.0.0-preview (#354) * F# - migrate bike sharing sample * F# - migrate spam sample * F# - migrate fraud sample * F# - migrate customer seg sample * F# - migrate iris classification sample * F# - migrate iris cluster sample * F# migrate sentiment sample * F# migrate taxi sample * rename solution * F# migrate tensorflow image classification sample * Label 'Count' column as 'Label' * print full trainer name * print absolute path * sentiment data update, some formatting updates * update tensorflow model * F# migrate issue labeler * update readme * update readme * Fix type-o: 'speccifying' => 'specifying' (#370) * F# update spam sample method (#366) * Fixed package issue. * AutoML API Test * Dataviews in AutoML * Cleaning up AutoML binary sample * Multiclass AutoML Sample * Fixing comments * AutoML Regression Sample * Added launchSettings.json to git (#381) * Minor Scalable.WebAPI changes (#382) * Added launchSettings.json to git * Removed part of sample included by mistake * Small fixes- display todos * Restructure files; rev AutoML binray classification sample * Rev Regression AutoML sample * restore experiment times to 60 seconds * Advanced experiment sample * bump experiment time * rev-ed due to feedback * break advanced sample into more modular methods * update step #s * fix comment * move stopwatch * remove unnecessary comment * capitalization fix * lots of revs * file path fix * delete final prediction * add progress handlers * Rev individual SLN files and delete READMEs * print exceptions if any in progress handlers * rev README.md * revert unnecessary changes * undo unneeded changes * revert datasets.md * Rev namespaces * restructure directory * undo unnecessary delete * print top models * Set CacheDirectory to null in advaned experiment * top model printing fix * Samples readmes * Regression README * Advanced Samples README * Edit AutoML binary classification sentiment analysis README * Binary README rev * README rev * README rev * README rev * README rev * unify heading size * README updates * rev * rev * revert unnecessary deletes * README fix * remove plot from advanced sample * Remove unneeded new line * add comment to progress handlers class * Remove unneeded blank lines at beginning of each solutions * Iterate on advanced README * Iterate to print headers; print list of top AutoML models before complete set of metrics from best model * README fix * Upgrade to AutoML from NuGet! * READMEs: In AutoML definition, remove dependence on training scores * Update samples/csharp/getting-started/BinaryClassification_AutoML/README.md Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/MulticlassClassification_AutoML/README.md Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/Regression_AutoML/TaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/Regression_AutoML/TaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/Regression_AutoML/TaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/Regression_AutoML/TaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/Regression_AutoML/TaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/Regression_AutoML/TaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * account for null / NaN metrics when computing top models * Re-fit pipeline on train & test data at the end of advanced sample * Merge commit that deletes dataset folder * Add back datasets folder with AutoML datasets * Add back in datasets * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/MulticlassClassification_AutoML/MNIST/DataStructures/SampleMNISTData.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/MulticlassClassification_AutoML/MNIST/DataStructures/SampleMNISTData.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/Regression_AutoML/TaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com> * Update samples/csharp/getting-started/AdvancedExperiment_AutoML/AdvancedTaxiFarePrediction/Program.cs Co-Authored-By: daholste <43974253+daholste@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.