Adding support for most learning tasks to PFI #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogancarr
requested review from
glebuk
and removed request for
TomFinley and
Ivanidzo4ka
shmoradims
reviewed
Dec 7, 2018
src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs
Outdated
Show resolved
Hide resolved
shmoradims
reviewed
Dec 7, 2018
src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs
Outdated
Show resolved
Hide resolved
shmoradims
reviewed
Dec 7, 2018
src/Microsoft.ML.Transforms/PermutationFeatureImportanceExtensions.cs
Outdated
Show resolved
Hide resolved
shmoradims
reviewed
Dec 7, 2018
…d put array delta calculations into a helper function.
wschin
reviewed
Dec 10, 2018
| IPredictionTransformer<IPredictor> model, | ||
| IDataView data, | ||
| string label = DefaultColumnNames.Label, | ||
| string features = DefaultColumnNames.Features, |
There was a problem hiding this comment.
It needs to be a list per its description. Also, FFM is a case one can have multiple feature columns.
There was a problem hiding this comment.
This is a really good point. Field-Aware Factorization Machines and at least one other internal learner have multiple feature columns, which is not supported by PFI. I'm going to add this as a separate fix, because it's a somewhat-orthogonal issue and might be a bit extensive.
Good find!
wschin
reviewed
Dec 10, 2018
| public void TestPfiMulticlassClassificationOnDenseFeatures() | ||
| { | ||
| var data = GetDenseDataset(TaskType.MulticlassClassification); | ||
| var model = ML.MulticlassClassification.Trainers.LogisticRegression().Fit(data); |
There was a problem hiding this comment.
Could you add a test using FFM with multiple feature columns?
There was a problem hiding this comment.
(See previous comment)
artidoro
approved these changes
Dec 12, 2018
| /// y = 10x1 + 10x2vBuff + 30x3 + e. | ||
| /// Within xBuff feature 2nd slot will be sparse most of the time. | ||
| /// 2nd slot of xBuff has the least importance: Evaluation metrics do not change a lot when this slot is permuted. | ||
| /// x2 has the biggest importance. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to
Permutation Feature ImportanceforMulticlass Classification,Ranking, andClustering.Fixes #1771