New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for most learning tasks to PFI #1832

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@rogancarr
Contributor

rogancarr commented Dec 5, 2018

This PR adds support to Permutation Feature Importance for Multiclass Classification, Ranking, and Clustering.

Fixes #1771

@rogancarr rogancarr requested review from shmoradims and TomFinley Dec 5, 2018

@Ivanidzo4ka Ivanidzo4ka self-requested a review Dec 7, 2018

@rogancarr rogancarr requested review from glebuk and removed request for TomFinley and Ivanidzo4ka Dec 7, 2018

Cleaning up in response to PR comments: Changed throws to asserts, an…
…d put array delta calculations into a helper function.
IPredictionTransformer<IPredictor> model,
IDataView data,
string label = DefaultColumnNames.Label,
string features = DefaultColumnNames.Features,

This comment has been minimized.

@wschin

wschin Dec 10, 2018

Member

It needs to be a list per its description. Also, FFM is a case one can have multiple feature columns.

public void TestPfiMulticlassClassificationOnDenseFeatures()
{
var data = GetDenseDataset(TaskType.MulticlassClassification);
var model = ML.MulticlassClassification.Trainers.LogisticRegression().Fit(data);

This comment has been minimized.

@wschin

wschin Dec 10, 2018

Member

Could you add a test using FFM with multiple feature columns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment