Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a new CI leg for netframework #2018

Merged
merged 4 commits into from
Jan 10, 2019
Merged

Adding a new CI leg for netframework #2018

merged 4 commits into from
Jan 10, 2019

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Jan 4, 2019 •
edited
Loading

Fixes #1933
We are currently not running or building our tests on netframework.
However we are going to support netframework when we release 1.0 , so just adding a new ci leg to consistently build and test stuff on netframework

@artidoro
Copy link
Contributor

artidoro commented Jan 4, 2019 •
edited
Loading

Since you are working on this could you order the CI legs alphabetically?

safern
safern reviewed Jan 4, 2019
View reviewed changes
build/ci/phase-template.yml Outdated Show resolved Hide resolved
safern
safern reviewed Jan 4, 2019
View reviewed changes
test/Directory.Build.props Outdated Show resolved Hide resolved
@Anipik Anipik changed the title Adding a new CI leg for netframework [WIP] Adding a new CI leg for netframework Jan 8, 2019
eerhardt
eerhardt reviewed Jan 9, 2019
View reviewed changes
config.json Outdated Show resolved Hide resolved
eerhardt
eerhardt reviewed Jan 9, 2019
View reviewed changes
config.json Outdated Show resolved Hide resolved
eerhardt
eerhardt reviewed Jan 9, 2019
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
eerhardt
eerhardt reviewed Jan 9, 2019
View reviewed changes
test/Directory.Build.props Outdated Show resolved Hide resolved
@Anipik Anipik changed the title [WIP] Adding a new CI leg for netframework Adding a new CI leg for netframework Jan 10, 2019
safern
safern reviewed Jan 10, 2019
View reviewed changes
config.json Show resolved Hide resolved
safern
safern reviewed Jan 10, 2019
View reviewed changes
test/Directory.Build.props Outdated Show resolved Hide resolved
safern
safern reviewed Jan 10, 2019
View reviewed changes
.vsts-dotnet-ci.yml Outdated Show resolved Hide resolved
safern
safern approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@safern safern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than 2 comments, LGTM.

This looks way better and it also enables people building for netfx from VS. Did you test that choosing that configuration worked fine? Intellisense and all the VS features?

@safern @Anipik
Update test/Directory.Build.props
d8727ce 
Co-Authored-By: Anipik <anirudhagnihotry098@gmail.com>
safern
safern suggested changes Jan 10, 2019
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're building the netfx matrix against netcoreapp2.1

.vsts-dotnet-ci.yml Outdated Show resolved Hide resolved
.vsts-dotnet-ci.yml Outdated Show resolved Hide resolved
@Anipik
Copy link
Contributor Author

Anipik commented Jan 10, 2019

This looks way better and it also enables people building for netfx from VS. Did you test that choosing that configuration worked fine? Intellisense and all the VS features?

The build from VS is working fine. the test explorer is giving some trouble. I will try to give it another try. (could be becuase of my VS as VS2019 is not working smoothly for me)

safern
safern approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

eerhardt
eerhardt approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Anipik
Copy link
Contributor Author

Anipik commented Jan 10, 2019

Thanks to @safern and @eerhardt for both feedback and help

@Anipik Anipik merged commit 64b60d2 into dotnet:master Jan 10, 2019
@Anipik Anipik deleted the netfxCi branch January 10, 2019 17:33
@shauheen
Copy link
Contributor

#2104 #2106 need to be addressed.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@eerhardt eerhardt eerhardt approved these changes

@safern safern safern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Anipik @artidoro @shauheen @danmoseley @eerhardt @safern