Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running tests against .NET Framework #1933

Closed
danmoseley opened this issue Dec 20, 2018 · 1 comment
Closed

Enable running tests against .NET Framework #1933

danmoseley opened this issue Dec 20, 2018 · 1 comment
Assignees

Comments

@danmoseley
Copy link
Member

Right now the tests are only built and run against netcoreapp2.1. We want to be able to run our unit tests on .NET Framework as well, as we will support that when we release 1.0

  1. The build part is because of here. The tests either need to be built against netstandard2.0 or multitargeted. Building against netstandard2.0 (modifying the line above) fails because the tests depend on the package xunit.runner.visualstudio 2.4.0 which it happens does not have support for netstandard2.0. So probably this line needs to be changed to something like <DefaultTestTargetFramework>net461,netstandard2.0</DefaultTestTargetFramework> (comma separated) so that it produces assets for both. Not sure which version of .NET Framework to use here. Whichever it is, the developer will need reference assemblies installed so perhaps we can pick whatever the default is for those.

  2. The running part I did not investigate. Maybe the above is sufficient and it's just another flag to pass to run against .NET Framework.

@danmoseley
Copy link
Member Author

cc @ericstj @Anipik

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants