ApplyOnnxModel sample #3349
ApplyOnnxModel sample #3349
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3349 +/- ##
=========================================
Coverage ? 72.7%
=========================================
Files ? 807
Lines ? 145172
Branches ? 16225
=========================================
Hits ? 105542
Misses ? 35217
Partials ? 4413
|
| { | ||
| /// <summary> | ||
| /// Example use of OnnxEstimator in an ML.NET pipeline | ||
| /// Example use of ApplyOnnxModel in an ML.NET pipeline | ||
| /// </summary> |
There was a problem hiding this comment.
let's delete this
(it's stating the obvious and we don't have it for other samples) #Resolved
| @@ -18,29 +18,17 @@ public static void Example() | |||
| // Microsoft.ML.Onnx.TestModels nuget. | |||
| var modelPath = @"squeezenet\00000001\model.onnx"; | |||
There was a problem hiding this comment.
Please verify that this statement is true (you can double check with Jignesh):
-
verify github link: Is the model.onnx in the squeezenet github link the same as squeezenet\00000001\model.onnx? I see manifest.json and 00000001 on our side which don't exist in the github link. Jignesh most likely has done an extra step to create squeezenet\00000001\model.onnx which users wouldn't know how to do.
-
verify the nuget: Microsoft.ML.Onnx.TestModels was last updated 4 months ago on myget. It's also at version 0.0.4: https://dotnet.myget.org/feed/dotnet-core/package/nuget/Microsoft.ML.Onnx.TestModels
We also have this other similar nuget: https://dotnet.myget.org/feed/dotnet-core/package/nuget/Microsoft.ML.Onnx.TestModels
There has been a lot of reshuffling things. Please double check that we're naming the correct nuget package and also try it out locally to make sure it works.
If there are any nuances about using this API, please add it to it's xml documentation.
Thanks.
#Resolved
There was a problem hiding this comment.
we're using regular // comments instead of /// (because the examples get pasted verbatim, and no xml is parsed). please change it here and below. #Resolved Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/OnnxTransform.cs:59 in 1011013. [](commit_id = 1011013, deletion_comment = False) |
| /// <summary> | ||
| /// inputSize is the overall dimensions of the model input tensor. | ||
| /// </summary> | ||
| // <summary> |
There was a problem hiding this comment.
i mean let's delete the xml tags like
and just keep the comment text:
// inputSize is the overall dimensions of the model input tensor. #Resolved
ghost
locked as resolved and limited conversation to collaborators
part of #1209