Fix NgramExtractingTransformer GetSlotNames to not allocate a new delegate on every invoke. #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egate on every invoke. This was showing up as allocating a huge number of delegates for no reason.
|
Using @ganik's NimbusML PR as a test benchmark, I'm seeing the following results. Before this change: After: |
KsenijaS
pushed a commit
to KsenijaS/machinelearning
that referenced
this pull request
Sep 27, 2019
…egate on every invoke. (dotnet#4247) This was showing up as allocating a huge number of delegates for no reason.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was showing up as allocating a huge number of delegates for no reason.
I removed the delegate all together and just pass the VBuffer in.