-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ranking AutoML Task #5150
Conversation
d89d1e9
to
705a436
Compare
Codecov Report
@@ Coverage Diff @@
## master #5150 +/- ##
==========================================
+ Coverage 73.47% 73.57% +0.09%
==========================================
Files 1010 1013 +3
Lines 187974 188446 +472
Branches 20261 20289 +28
==========================================
+ Hits 138120 138649 +529
+ Misses 44372 44316 -56
+ Partials 5482 5481 -1
|
ColumnInformation columnInfo, IDataView validationSet) | ||
{ | ||
LightGbmRankingTrainer.Options options = TrainerExtensionUtil.CreateLightGbmOptions<LightGbmRankingTrainer.Options, | ||
float, RankingPredictionTransformer<LightGbmRankingModelParameters>, LightGbmRankingModelParameters>(sweepParams, columnInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh that's crazy
src/Microsoft.ML.AutoML/TrainerExtensions/TrainerExtensionCatalog.cs
Outdated
Show resolved
Hide resolved
@@ -420,6 +446,10 @@ public static SuggestedTransform[] InferTransforms(MLContext context, TaskKind t | |||
var labelColumnName = intermediateCols.FirstOrDefault(c => c.Purpose == ColumnPurpose.Label)?.ColumnName; | |||
concatColNames.Remove(labelColumnName); | |||
|
|||
// remove column with 'GroupId' purpose | |||
var groupColumnName = intermediateCols.FirstOrDefault(c => c.Purpose == ColumnPurpose.GroupId)?.ColumnName; | |||
concatColNames.RemoveAll(s => s == groupColumnName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to remove "GroupId" too because it's a key column, it can't be cocat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the custom GroupId column change to another PR. That's why there's only groupColumnName removed here.
src/Microsoft.ML.CodeGenerator/CodeGenerator/CSharp/TrainerGenerators.cs
Outdated
Show resolved
Hide resolved
...lTests/ConsoleCodeGeneratorTests.ConsoleAppModelBuilderCSFileContentRankingTest.approved.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a ranking experiment in AutoML - sweeping over predefined parameters for two trainers - FastTreeRanking and LightGBMRanking.
ModelBuilder Requests:
Next Steps: Fully integrate with modelbuilder