Enabling custom groupId column in the Ranking AutoML experiment #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5246 +/- ##
==========================================
+ Coverage 73.51% 73.55% +0.04%
==========================================
Files 1013 1022 +9
Lines 188446 189693 +1247
Branches 20289 20441 +152
==========================================
+ Hits 138528 139534 +1006
- Misses 44426 44619 +193
- Partials 5492 5540 +48
|
wangyems
reviewed
Jun 18, 2020
harishsk
reviewed
Jun 22, 2020
src/Microsoft.ML.AutoML/Experiment/MetricsAgents/BinaryMetricsAgent.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.AutoML/Experiment/MetricsAgents/IMetricsAgent.cs
Outdated
Show resolved
Hide resolved
| @@ -57,9 +57,9 @@ public bool IsModelPerfect(double score) | |||
| } | |||
| } | |||
|
|
|||
| public RankingMetrics EvaluateMetrics(IDataView data, string labelColumn) | |||
| public RankingMetrics EvaluateMetrics(IDataView data, string labelColumn, string groupIdColumn) | |||
There was a problem hiding this comment.
Can we just put groupId column as an option when creating RankingMetricsAgent? So that we don't have to add an extra groupIdColumn to IAgent.
There was a problem hiding this comment.
Yes, we can do that. I think a possible concern is that GroupId is required by RankingTrainers, and passing it in as an option gives me the impression that it's optional. I think that if we make the default value of GroupId "GroupId" and document that, it might be okay. What you do think?
LittleLittleCloud
previously approved these changes
Jun 26, 2020
LittleLittleCloud
approved these changes
Jun 30, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.