Fix CarouselView sizing. (#422)

dotnet · Jan 23, 2024 · fb4a832 · fb4a832
1 parent 7312fd7
commit fb4a832
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 22 deletions.
diff --git a/...erInterface/Views/IndicatorViewDemos/IndicatorViewDemos/Views/BasicIndicatorViewPage.xaml b/...erInterface/Views/IndicatorViewDemos/IndicatorViewDemos/Views/BasicIndicatorViewPage.xaml
@@ -7,9 +7,9 @@
     <ContentPage.BindingContext>
         <viewmodels:MonkeysViewModel />
     </ContentPage.BindingContext>
-    <StackLayout Margin="10">
-        <CarouselView HeightRequest="400"
-                      ItemsSource="{Binding Monkeys}"
+    <Grid Margin="10"
+          RowDefinitions="*,Auto">
+        <CarouselView ItemsSource="{Binding Monkeys}"
                       IndicatorView="indicatorView">
             <CarouselView.ItemTemplate>
                 <DataTemplate>
@@ -46,10 +46,11 @@
             </CarouselView.ItemTemplate>
         </CarouselView>
         <IndicatorView x:Name="indicatorView"
+                       Grid.Row="1"
                        MaximumVisible="6"
                        Margin="0,0,0,40"
                        IndicatorColor="LightGray"
                        SelectedIndicatorColor="DarkGray"
                        HorizontalOptions="Center" />
-    </StackLayout>
+    </Grid>
 </ContentPage>
diff --git a/...face/Views/IndicatorViewDemos/IndicatorViewDemos/Views/ConfigurableIndicatorViewPage.xaml b/...face/Views/IndicatorViewDemos/IndicatorViewDemos/Views/ConfigurableIndicatorViewPage.xaml
@@ -8,20 +8,9 @@
     <ContentPage.BindingContext>
         <viewmodels:MonkeysViewModel />
     </ContentPage.BindingContext>
-    <Grid Margin="10">
-        <Grid.RowDefinitions>
-            <RowDefinition Height="Auto" />
-            <RowDefinition Height="Auto" />
-            <RowDefinition Height="Auto" />
-            <RowDefinition Height="Auto" />
-            <RowDefinition Height="Auto" />
-            <RowDefinition Height="Auto" />
-            <RowDefinition Height="Auto" />
-        </Grid.RowDefinitions>
-        <Grid.ColumnDefinitions>
-            <ColumnDefinition Width="0.5*" />
-            <ColumnDefinition Width="0.5*" />
-        </Grid.ColumnDefinitions>
+    <Grid Margin="10"
+          RowDefinitions="Auto,Auto,Auto,Auto,Auto,*,Auto"
+          ColumnDefinitions="0.5*,0.5*">
         <Label Text="IndicatorColor:"
                HorizontalOptions="End"
                VerticalTextAlignment="Center" />

diff --git a/...terface/Views/IndicatorViewDemos/IndicatorViewDemos/Views/TemplatedIndicatorViewPage.xaml b/...terface/Views/IndicatorViewDemos/IndicatorViewDemos/Views/TemplatedIndicatorViewPage.xaml
@@ -32,9 +32,9 @@
         </Style>
     </ContentPage.Resources>
 
-    <StackLayout Margin="10">
-        <CarouselView HeightRequest="400"
-                      ItemsSource="{Binding Monkeys}"
+    <Grid Margin="10"
+          RowDefinitions="*,Auto">
+        <CarouselView ItemsSource="{Binding Monkeys}"
                       IndicatorView="indicatorView">
             <CarouselView.ItemTemplate>
                 <DataTemplate>
@@ -72,7 +72,9 @@
         </CarouselView>
 
         <IndicatorView x:Name="indicatorView"
+                       Grid.Row="1"
                        Margin="0,0,0,40"
+                       MaximumVisible="12"
                        IndicatorColor="Transparent"
                        SelectedIndicatorColor="Transparent"
                        HorizontalOptions="Center">
@@ -85,5 +87,5 @@
                 </DataTemplate>
             </IndicatorView.IndicatorTemplate>
         </IndicatorView>
-    </StackLayout>
+    </Grid>
 </ContentPage>