-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[release/6.0.1xx-rc1] Update dependencies from xamarin/xamarin-android (
#2369) * Update dependencies from https://github.com/xamarin/xamarin-android build 6.0.1xx-rc1-3793f6e34c40e3aa1a00d0dbe6dd0d706283e197-1 Microsoft.Android.Sdk.Windows From Version 31.0.100-rc.1.12 -> To Version 31.0.100-rc.1.16 Dependency coherency updates Microsoft.NETCore.App.Ref,Microsoft.Dotnet.Sdk.Internal,Microsoft.Extensions.Primitives,Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.Extensions.Hosting,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.AspNetCore.Authorization,Microsoft.AspNetCore.Components.WebView,Microsoft.AspNetCore.Components.Web,Microsoft.JSInterop,Microsoft.WindowsDesktop.App.Runtime.win-x64,System.CodeDom From Version 6.0.0-rc.1.21426.8 -> To Version 6.0.0-rc.1.21451.13 (parent: Microsoft.Dotnet.Sdk.Internal * Remove incorrect LangVersion 9.0 and use default Razor Source Generator needs at least 10.0 * Explicitly set LangVersion=10.0 * Use $(LangVersion) preview, because dotnet/maui builds with VS Context: dotnet/sdk@10efeed...454eae3 This was removed from the dotnet/sdk: <!-- Required to support incremental source generator --> <LangVersion Condition="'$(UseRazorSourceGenerator)' != '' ">preview</LangVersion> So I think we need to opt into `preview` to build with the older Roslyn in VS. * Keep Controls.Core.UnitTests on C# 9 This apparently breaks NUnit `Assert.That()` calls. I could build the project locally after this change. * Try start vs4mac with local dotnet * Revert "Try start vs4mac with local dotnet" This reverts commit 85ce42d. * Update LifecycleEventsTests.cs I think we might also be hitting some method overloading issues in these test failures: * `CanAddMultipleEventsViaMultipleConfigureLifecycleEvents` * `CanAddMultipleEventsViaBuilder` * `EventsFireExactlyOnce` * Revert "Update LifecycleEventsTests.cs" This reverts commit 90c233d. * Keep Core.UnitTests on C# 9 This solves 3 test failures: > .\bin\dotnet\dotnet.exe test src\Core\tests\UnitTests\Core.UnitTests-net6.csproj -bl ... [xUnit.net 00:00:00.60] CanAddMultipleEventsViaMultipleConfigureLifecycleEvents [FAIL] Failed CanAddMultipleEventsViaMultipleConfigureLifecycleEvents [10 ms] Error Message: Assert.Equal() Failure Expected: 1 Actual: 0 Stack Trace: at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.CanAddMultipleEventsViaMultipleConfigureLifecycleEvents() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 134 [xUnit.net 00:00:00.62] EventsFireExactlyOnce [FAIL] [xUnit.net 00:00:00.62] CanAddMultipleEventsViaBuilder [FAIL] Failed EventsFireExactlyOnce [2 ms] Error Message: Assert.Equal() Failure Expected: 1 Actual: 0 Stack Trace: at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.EventsFireExactlyOnce() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 75 Failed CanAddMultipleEventsViaBuilder [2 ms] Error Message: Assert.Equal() Failure Expected: 1 Actual: 0 Stack Trace: at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.CanAddMultipleEventsViaBuilder() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 156 Failed! - Failed: 3, Passed: 367, Skipped: 0, Total: 370, Duration: 192 ms - Microsoft.Maui.UnitTests.dll (net6.0) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com> Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> Co-authored-by: Rui Marinho <me@ruimarinho.net>
- Loading branch information
1 parent
d2ffa35
commit 294dff1
Showing
8 changed files
with
78 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
src/Controls/samples/Controls.Sample.iOS/Controls.Sample.iOS.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters