Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Splash Screen BaseSize broken #10275

Closed
nor0x opened this issue Sep 22, 2022 · 4 comments · Fixed by #10516
Closed

[Android] Splash Screen BaseSize broken #10275

nor0x opened this issue Sep 22, 2022 · 4 comments · Fixed by #10516
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer fixed-in-7.0.49 Look for this fix in 7.0.49 GA! fixed-in-7.0.100 fixed-in-7.0.101 platform/android 🤖 t/bug Something isn't working

Comments

@nor0x
Copy link
Contributor

nor0x commented Sep 22, 2022

Description

i have set a non-square SVG as my splash screen and changed the BaseSize accordingly.

<MauiSplashScreen Include="Resources\Splash\splash.svg" Color="#512BD4" BaseSize="151,80" />

nor0x/MauiFails@17b2040#diff-a0f7032d60e5462377d9323a6d81e9028fa2a86c70358cc59215c88ac22ec6c2

this however is not working correctly on Android and the splash image is squeezed into a square.

this happens in the net7.0 RC1 and was working correctly before that.

I suspect that #9797 and especially the fixed sizes are causing this?

it turns out its the android:gravity of the image \obj\Debug\net6.0-android\resizetizer\sp\maui_splash_image.xml if i change it from fill to center the splash screen works fine.

image

Steps to Reproduce

  1. Create new maui app
  2. set non-square splash image
  3. change BaseSize

Link to public reproduction project repository

https://github.com/nor0x/MauiFails

Version with bug

Unknown/Other (please specify)

Last version that worked well

6.0.424

Affected platforms

Android

Affected platform versions

tested on Android 11

Did you find any workaround?

locate \obj\Debug\net6.0-android\resizetizer\sp\maui_splash_image.xml and change the android:gravity from fill to center

Relevant log output

No response

@nor0x nor0x added the t/bug Something isn't working label Sep 22, 2022
nor0x added a commit to nor0x/MauiFails that referenced this issue Sep 22, 2022
i wonder if there is a future were splash screens and icons are working correctly in maui

dotnet/maui#10275
nor0x added a commit to nor0x/maui that referenced this issue Sep 22, 2022
@rachelkang rachelkang added this to the Backlog milestone Sep 23, 2022
@ghost
Copy link

ghost commented Sep 23, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@Eilon Eilon added the area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer label Sep 23, 2022
@mattleibow
Copy link
Member

This is going to be fixed with #10516

@MobileDev327
Copy link

Description

i have set a non-square SVG as my splash screen and changed the BaseSize accordingly.

<MauiSplashScreen Include="Resources\Splash\splash.svg" Color="#512BD4" BaseSize="151,80" />

nor0x/MauiFails@17b2040#diff-a0f7032d60e5462377d9323a6d81e9028fa2a86c70358cc59215c88ac22ec6c2

this however is not working correctly on Android and the splash image is squeezed into a square.

this happens in the net7.0 RC1 and was working correctly before that.
I suspect that #9797 and especially the fixed sizes are causing this?

it turns out its the android:gravity of the image \obj\Debug\net6.0-android\resizetizer\sp\maui_splash_image.xml if i change it from fill to center the splash screen works fine.

image

Steps to Reproduce

  1. Create new maui app
  2. set non-square splash image
  3. change BaseSize

Link to public reproduction project repository

https://github.com/nor0x/MauiFails

Version with bug

Unknown/Other (please specify)

Last version that worked well

6.0.424

Affected platforms

Android

Affected platform versions

tested on Android 11

Did you find any workaround?

locate \obj\Debug\net6.0-android\resizetizer\sp\maui_splash_image.xml and change the android:gravity from fill to center

Relevant log output

No response

I noticed once I rebuild the project it sets it back to fill. Is anyone else seeing this? Is there a current workaround for that?

@ghost
Copy link

ghost commented Oct 24, 2022

Hello lovely human, thank you for your comment on this issue. Because this issue has been closed for a period of time, please strongly consider opening a new issue linking to this issue instead to ensure better visibility of your comment. Thank you!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2022
@samhouts samhouts added the fixed-in-7.0.49 Look for this fix in 7.0.49 GA! label Feb 16, 2023
@samhouts samhouts modified the milestones: Backlog, .NET 7 + Servicing Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-single-project Splash Screen, Multi-Targeting, MauiFont, MauiImage, MauiAsset, Resizetizer fixed-in-7.0.49 Look for this fix in 7.0.49 GA! fixed-in-7.0.100 fixed-in-7.0.101 platform/android 🤖 t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants