[regression/8.0.0-preview.5.8529] FlyoutPage Navigation broken in Android #18050
Assignees
Labels
area-controls-flyout
Flyout
fixed-in-8.0.6
Look for this fix in 8.0.6 SR1!
fixed-in-8.0.10
fixed-in-8.0.14
fixed-in-8.0.40
i/regression
This issue described a confirmed regression on a currently supported version
platform/android 🤖
t/bug
Something isn't working
Milestone
Comments
jsuarezruiz
added
area-controls-flyout
samhouts
changed the title
|
Confirmed that this regressed between 8.0.0-preview.4.8333 and 8.0.0-preview.5.8529. #14867 seems sus. |
samhouts
added
i/regression
samhouts
changed the title
|
Do I unterstand this correctly, that the milestone-change to .NET 8 SR1 means this regression will not be fixed with GA? |
emaf
added a commit
that referenced
this issue
Nov 10, 2023
This fix complements fb82b83 to fix toolbar issues when swapping Detail pages. That commit was necessary, but on Android we also need to make sure the `Toolbar.Handler` is disconnected, otherwise the old toolbar is never removed and we start stacking them. This was already happening for `Window` but not for `Page` . This code is now shared between both to avoid this problem where only one place is changed. Fixes #18050
emaf
added a commit
that referenced
this issue
Nov 14, 2023
This fix complements fb82b83 to fix toolbar issues when swapping Detail pages. That commit was necessary, but on Android we also need to make sure the `Toolbar.Handler` is disconnected, otherwise the old toolbar is never removed and we start stacking them. This was already happening for `Window` but not for `Page` . This code is now shared between both to avoid this problem where only one place is changed. Fixes #18050
PureWeen
added a commit
that referenced
this issue
Nov 15, 2023
* [Android] Fix Flyout toolbar This fix complements fb82b83 to fix toolbar issues when swapping Detail pages. That commit was necessary, but on Android we also need to make sure the `Toolbar.Handler` is disconnected, otherwise the old toolbar is never removed and we start stacking them. This was already happening for `Window` but not for `Page` . This code is now shared between both to avoid this problem where only one place is changed. Fixes #18050 * Add missing condition * Make test run on all platforms and fix iOS back button check - Moved test to FlyoutPageTests since it tests both Flyout and Navigation. - Changed iOS HasBackButton check to check if there is a BackItem, otherwise we were checking for any button in the navigation bar, so it was returning true even for the flyout button. * Fix condition * Skip MacCatalyst * - fix test timings * Stop skipping MacCatalyst --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
|
Glad to see this issue fixed. Thanks @emaf. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
2 major issues with FlyoutPage Navigation in .NET 8 RC2, breaking existing applications using FlyoutPage:
Bildschirmaufnahme.2023-10-16.um.14.45.45.mov
Steps to Reproduce
See repro project
Link to public reproduction project repository
https://github.com/FlavioGoncalves-Cayas/FlyoutNavigationTest
Version with bug
8.0.0-preview.5.8529
Is this a regression from previous behavior?
Yes, this used to work in .NET MAUI
Last version that worked well
8.0.0-preview.4.8333
Affected platforms
Android
Affected platform versions
Android 13
Did you find any workaround?
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: