[Android] Fix Flyout toolbar #18684
Merged
[Android] Fix Flyout toolbar #18684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Can you move the test created here so that it runs on Android/iOS as well?
I think if we'd originally had that test running on Android/iOS we would have caught this.
Whenever we can apply a test to all three platforms that's ideal!
PureWeen
previously approved these changes
Nov 14, 2023
This fix complements fb82b83 to fix toolbar issues when swapping Detail pages. That commit was necessary, but on Android we also need to make sure the `Toolbar.Handler` is disconnected, otherwise the old toolbar is never removed and we start stacking them. This was already happening for `Window` but not for `Page` . This code is now shared between both to avoid this problem where only one place is changed. Fixes #18050
- Moved test to FlyoutPageTests since it tests both Flyout and Navigation. - Changed iOS HasBackButton check to check if there is a BackItem, otherwise we were checking for any button in the navigation bar, so it was returning true even for the flyout button.
emaf
force-pushed
the
dev/ema/toolbar
branch
from
4790451
to
acb453c
Compare
PureWeen
approved these changes
Nov 14, 2023
This was referenced Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This fix complements fb82b83 to fix toolbar issues when swapping Detail pages. That commit was necessary, but on Android we also need to make sure the
Toolbar.Handleris disconnected, otherwise the old toolbar is never removed and we start stacking them.This was already happening for
Windowbut not forPage. This code is now shared between both to avoid this problem where only one place is changed.Issues Fixed
Fixes #18050