Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configurability in opening external URLs #4338

Closed
TanayParikh opened this issue Jan 26, 2022 · 1 comment · Fixed by #4645
Closed

Support configurability in opening external URLs #4338

TanayParikh opened this issue Jan 26, 2022 · 1 comment · Fixed by #4645
Assignees
@TanayParikh
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! t/enhancement ☀️ New feature or request
Milestone
6.0.300-preview.14

Comments

@TanayParikh
Copy link
Contributor

TanayParikh commented Jan 26, 2022 •
edited
Loading

Description

Based on discussion in #4268 (comment).

Later on I think our goal from security review was to ensure that you can't navigate to external content in the app's webview by default, and that developers would explicitly have to configure or override something to allow that.

We may want to add an explicit option which permits opening external webpages in the browser.

Intended Use-Case

Open a link to a parcel courier service in the browser for a package being tracked.
@TanayParikh TanayParikh added the area-blazor Blazor Hybrid / Desktop, BlazorWebView label Jan 26, 2022
@TanayParikh TanayParikh mentioned this issue Jan 26, 2022
Merged
@mkArtakMSFT mkArtakMSFT added the t/enhancement ☀️ New feature or request label Jan 27, 2022
@mkArtakMSFT mkArtakMSFT mentioned this issue Feb 8, 2022
Closed
@TanayParikh TanayParikh self-assigned this Feb 11, 2022
@TanayParikh TanayParikh mentioned this issue Feb 12, 2022
Merged
6 tasks
@codemonkey85

This comment was marked as duplicate.

Sign in to view
TanayParikh added a commit that referenced this issue Feb 14, 2022
@TanayParikh
Blazor Windows Open Links in Browser with Configurability
b78a939 
Windows portion of #4338
@TanayParikh TanayParikh mentioned this issue Feb 14, 2022
Merged
TanayParikh added a commit that referenced this issue Feb 15, 2022
@TanayParikh
Blazor Windows Open Links in Browser with Configurability (#4680)
817166a 
* Blazor Windows Open Links in Browser with Configurability

Windows portion of #4338

* TryCreate URI
TanayParikh added a commit that referenced this issue Feb 24, 2022
@TanayParikh
Blazor Open Links in Browser with Configurability (#4645)
78c1ffe 
* Blazor Android Open Links in Browser with Configurability

* Blazor Windows Open Links in Browser with Configurability (#4680)

* Blazor Windows Open Links in Browser with Configurability

Windows portion of #4338

* TryCreate URI

* PR Feedback

(cherry picked from commit 35f637e)

* OnExternalNavigationStarting

* Pranav Points

* Event based approach

* Info -> EventArgs

* iOS & Mac Catalyst

* Fix WPF/Winforms Browser Start

* Winforms ExternalNavigationStarting

* PR Feedback

* Remove ordering dependency during property mapping

* @blowdart feedback

* @Eilon feedback
@mkArtakMSFT mkArtakMSFT added this to the 6.0.300-preview.14 milestone Mar 24, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2022
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TanayParikh TanayParikh

Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! t/enhancement ☀️ New feature or request
Projects
None yet
Milestone
6.0.300-preview.14
Development

Successfully merging a pull request may close this issue.

Blazor Open Links in Browser with Configurability dotnet/maui
4 participants
@codemonkey85 @samhouts @TanayParikh @mkArtakMSFT