Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates] remove Directory.Build.targets, add @(ProjectCapability) #1433

Merged
merged 4 commits into from
Jul 26, 2021
Merged

[templates] remove Directory.Build.targets, add @(ProjectCapability) #1433

merged 4 commits into from
Jul 26, 2021

Commits on Jul 26, 2021

  1. [templates] remove Directory.Build.targets, add @(ProjectCapability) 

    The `Directory.Build.targets` files in the templates were a collection
of workarounds that were needed until .NET MAUI was a workload. When
.NET MAUI was a NuGet package, this was the only way to set required
values for the IDE before NuGet restore. In the early days, you had to
unload/reload MAUI projects after NuGet restore.

We can remove `Directory.Build.targets` from templates now, and
consolidate `@(ProjectCapability)` so this is defined by the workload.

The following capabilities are defined for the IDE:

* `Maui`
* When `$(SingleProject)` is `true`:
  * `MauiSingleProject`, `LaunchProfiles`
  * `XamarinStaticLaunchProfiles` older than Dev17
  * `LaunchProfilesGroupByPlatformFilters` otherwise

These new capabilities are defined to identify projects (via telemetry)
that bring in portions of .NET MAUI:

* `MauiAssets`
* `MauiBlazor`
* `MauiCore`
* `MauiEssentials`

Other changes:

* `$(_KeepLaunchProfiles)` is set by default when `$(SingleProject)`
  is `true`.
* WinUI workarounds are moved into `WinUI.SingleProject.targets`.
* Fixed `sdk-manifests` casing for `src/DotNet/DotNet.csproj -t:Install`
    @jonathanpeppers
    jonathanpeppers authored and Jonathan Dick committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    81062a7 View commit details
    Browse the repository at this point in the history

  2. Remove CI trimming workaround

    Jonathan Dick committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    acffb4a View commit details
    Browse the repository at this point in the history

  3. Update WinUI.SingleProject.targets

    @mattleibow
    mattleibow authored and Jonathan Dick committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    06b4d8c View commit details
    Browse the repository at this point in the history

  4. Update Directory.Build.targets

    @mattleibow
    mattleibow authored and Jonathan Dick committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    72f5134 View commit details
    Browse the repository at this point in the history