Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[net7.0] Fix edge case with Grids, *s, and unconstrained layouts #14369

Merged
merged 3 commits into from
Apr 11, 2023
Merged

[net7.0] Fix edge case with Grids, *s, and unconstrained layouts #14369

merged 3 commits into from
Apr 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 3, 2023 •
edited by rmarinho
Loading

Backport of #14114 to net7.0
Backport of #14315 to net7.0

/cc @rmarinho @hartez

@hartez @rmarinho
Ensure that second-pass measures of Auto rows/columns are allowed to …
693dcfe 
…expand (#14315)

Fixes #14296
# Conflicts:
#	src/Core/src/Layouts/GridLayoutManager.cs
@rmarinho
Copy link
Member

rmarinho commented Apr 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Apr 3, 2023
@rmarinho rmarinho linked an issue Apr 4, 2023 that may be closed by this pull request
Grid star (Image?) behaviour inconsistent across platforms #14305
Open
@mattleibow mattleibow mentioned this pull request Apr 4, 2023
Open
@hartez hartez mentioned this pull request Apr 10, 2023
Closed
@rmarinho rmarinho merged commit 7b16923 into net7.0 Apr 11, 2023
@rmarinho rmarinho deleted the backport/pr-14114-to-net7.0 branch April 11, 2023 00:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@samhouts samhouts added the fixed-in-7.0.92 Look for this fix in 7.0.92! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees
No one assigned
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-7.0.92 Look for this fix in 7.0.92!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grid star (Image?) behaviour inconsistent across platforms
5 participants
@rmarinho @hartez @mandel-macaque @Eilon @samhouts