Improve some test methods #14753
Merged
Improve some test methods #14753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
commented
Apr 24, 2023
Comment on lines
-472
to
+475
| throw new XunitException($"Color {expectedColor} not found."); | ||
| throw new XunitException(CreateColorError(bitmap, $"Color {expectedColor} not found.")); |
There was a problem hiding this comment.
Add the bitmap contents to the output.
Comment on lines
-251
to
+254
| var window = view.GetParentOfType<Window>() ?? throw new InvalidOperationException("View was attached to a window but there was no window."); | ||
| // Window is not a XAML type so is never on the hierarchy | ||
| var window = view.GetParentOfType<TestWindowRoot>()?.Window ?? throw new InvalidOperationException("View was attached to a window but there was no window."); |
There was a problem hiding this comment.
This would never work as Window is not a Xaml object.
Comment on lines
+368
to
+371
| public static Task<CanvasBitmap> AssertDoesNotContainColor(this CanvasBitmap bitmap, Graphics.Color unexpectedColor, Func<Graphics.RectF, Graphics.RectF>? withinRectModifier = null) | ||
| => bitmap.AssertDoesNotContainColor(unexpectedColor.ToWindowsColor(), withinRectModifier); | ||
|
|
||
| public static async Task<CanvasBitmap> AssertDoesNotContainColor(this CanvasBitmap bitmap, WColor unexpectedColor, Func<Graphics.RectF, Graphics.RectF>? withinRectModifier = null) |
There was a problem hiding this comment.
Add this missing assert.
| throw new XunitException($"Color {expectedColor} not found."); | ||
| throw new XunitException(CreateColorError(bitmap, $"Color {expectedColor} not found.")); |
There was a problem hiding this comment.
Add the bitmap contents to the output.
PureWeen
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Just improving some test methods.