Create better helpers for attaching and fix Window #14772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Apr 25, 2023
| "src\\Controls\\tests\\Xaml.UnitTests.InternalsHiddenAssembly\\Controls.Xaml.UnitTests.InternalsHiddenAssembly.csproj", | ||
| "src\\Controls\\tests\\Xaml.UnitTests.InternalsVisibleAssembly\\Controls.Xaml.UnitTests.InternalsVisibleAssembly.csproj", |
There was a problem hiding this comment.
For some reason VS keeps wanting to move this so, I'm hoping if we check this in then it'll just be content.
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
filipnavara
approved these changes
Apr 25, 2023
mattleibow
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
There are 1 or 2 places where things are not consistent - like some use the AttachAndRun(view) and the others use view.AttachAndRun(context) but this is super nitty and we can fix that as we see them. Maybe there was a reason for some or maybe not. But they all go to the same place and we can merge this PR
mattleibow
approved these changes
Apr 26, 2023
mattleibow
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is the next version of this PR.
AttachAndRunon Windows so that theWindowis created through theMauiContext. This is important because we have a few places inside our handlers where the window is retrieved via theMauiContextso those windows have to align.InitializingBackgroundUpdatesBackgroundthat useCreateHandlerAndAddToWindowand then make use ofAttachAndRun. This allowsAttachAndRunto retrieve the correct window as part of its code.AttachAndRunso that we don't have to always go through the ceremony ofcreatehandler/invokeonuithread/attachplatformview. Now you can just callAttachAndRunon theIViewand it'll take care of marshalling and creating for you.Known issues
The
WebViewHandlertests in core on windows are still crashing. Those will be addressed with a different PR because those crashes aren't really related to the changes here.