Transition away from implicit package references #14770
Conversation
Eilon
added
the
area-setup
| FileUtilities.ReplaceInFile(projectFile, | ||
| "</Project>", | ||
| "<PropertyGroup><Version>1.0.0-preview.1</Version></PropertyGroup></Project>"); | ||
|
|
||
| string target = shouldPack ? "Pack" : ""; |
There was a problem hiding this comment.
no your change, but string.Empty should have been used.
| ('@(_MauiImplicitRequiredPackageReference->Count())' != '0') "> | ||
|
|
||
| <PropertyGroup> | ||
| <_MauiValidateRefsPrefix>Starting with .NET 8, setting </_MauiValidateRefsPrefix> |
There was a problem hiding this comment.
These messages... @rmarinho what is the way to localize?
There was a problem hiding this comment.
Use resources? how do you pull into here I think I saw something about that
There was a problem hiding this comment.
@mcumming @pjcollins do you know?
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
I created an issue for the localization part: #14804
I found a few plain text strings that we need to localize across our targets.
|
Looks fine to me but I'd like @MackinnonBuck or @Eilon to review this too just in case there are things beyond my knowledge that can cause trouble down the road (specifically around Blazor). |
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
Description of Change
This PR checks and then adds a warning if it finds that the developer does not have a package reference to .NET MAUI in the project file. Implicit package references cause issues with the Package Manager UI as well as the CLI.
Not only do with fix some issues, developers can now have better control over the packages included and the transitive dependencies.
The project templates now have an additional package:
We are keeping the variable so that developers can choose to allow the IDE to update the version of .NET MAUI being used. This can be replaced with an explicit version, but then will no longer receive updates when the IDE is updated.
This PR replaces #14576
Future Work