Wait for root page to load before processing modal #15037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
fix_swapping_root_page_android
branch
from
214b36d
to
6da8086
Compare
rmarinho
approved these changes
May 18, 2023
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
* Wait for root page to load before processing modal * Update ModalTests.iOS.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
While testing #15020 I found a bug that's causing a crash when you try to swap out the root page when a modal page is currently open on android.
With the old gallery a lot of the tests have to swap out the
mainpagein order to run in an isolated context.The code change in this PR fixes
androidso that it waits to process the modal pages until the root page has been loaded. There was a timing issue where the modal page was being removed before the root page was loaded in which would cause an NRE.