Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up Compatibility gallery #15020

Merged
merged 10 commits into from
May 16, 2023
Merged

Fix up Compatibility gallery #15020

merged 10 commits into from
May 16, 2023

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented May 10, 2023 •
edited
Loading

Description of Change

  • Remove the compatibility project from all of our legacy gallery projects so we are only using new bits
    • I created a "Compatibility" folder inside each gallery where I moved all the renderers to since these won't compile anymore. The legacy gallery isn't testing any shims it's only meant to see how the new MAUI versions compare.
  • Change the namespace of all of the controls galleries so that they aren't using compatibility.Layouts
    • This is the primary change and why there are 2239 files being changed.
  • I'd say this file is the most interesting part of this PR. These are all the APIs that disappeared when switching back to the new layouts.

@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

@PureWeen PureWeen mentioned this pull request May 11, 2023
Merged
@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label May 12, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

@PureWeen PureWeen marked this pull request as ready for review May 14, 2023 00:07
@github-actions
Copy link
Contributor

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

rmarinho
rmarinho approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I was able to even get it to run against Xamarin.UITest for a couple of tests and was able to navigate to them etc.

rmarinho
rmarinho approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I was able to even get it to run against Xamarin.UITest for a couple of tests and was able to navigate to them etc.

@rmarinho rmarinho merged commit c0c5234 into main May 16, 2023
@rmarinho rmarinho deleted the compatibility_gallery branch May 16, 2023 16:31
rmarinho pushed a commit that referenced this pull request May 30, 2023
@PureWeen @rmarinho
Fix up Compatibility gallery (#15020)
3b86fc6 
* Remove Compat components from legacy gallery

* - cleanup android gallery

* - remove diagnose capability

* - fix up WinUI to run

* - last few missing files on winui

* - fix iOS to compile

* Auto-format source code

* - fix compile errors

* - fixup test agent search

* Auto-format source code

---------

Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis

@mattleibow mattleibow Awaiting requested review from mattleibow

Assignees
No one assigned
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PureWeen @rmarinho @Eilon @samhouts