[net8.0] Fix cells leak tests #16231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
reviewed
Jul 19, 2023
| } | ||
| } | ||
| //[Fact("Cells Do Not Leak")] | ||
| //public async Task CellsDoNotLeak() |
There was a problem hiding this comment.
Better use just Skip with a comment (the comment will help to understand the status). Also, should we create a related issue where @jonathanpeppers could work?
jonathanpeppers
previously requested changes
Jul 19, 2023
There was a problem hiding this comment.
Let's fix this test. Can you share cases where it failed?
It's already caught a new leak that was introduced in: #15856
|
@jonathanpeppers first time it started was with Android bump commit 310d5d4 doesn't make much sense |
|
Let's try this: #16237 And then it's possible there is something that is going wrong in .NET 8? If this still fails. |
I've found the most reliable way to make DeviceTests
run the GC for all platforms is:
Assert.NotNull(pageReference);
await AssertionExtensions.Wait(() =>
{
GC.Collect();
GC.WaitForPendingFinalizers();
return !pageReference.IsAlive;
}, timeout: 5000);
Let's standardize on this, so we can instead do:
await AssertionExtensions.WaitForGC(pageReference);
And if you have multiple:
await AssertionExtensions.WaitForGC(pageReference, handlerReference);
The helper method also checks if the `params WeakReference[]` is empty,
or any `WeakReference` are null. I simplified various tests with this
change.
# Conflicts:
# src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.iOS.cs
Redth
approved these changes
Jul 20, 2023
| GC.Collect(); | ||
| GC.WaitForPendingFinalizers(); | ||
|
|
||
| await AssertionExtensions.WaitForGC(labels.ToArray()); |
There was a problem hiding this comment.
Ok awesome! Glad this fixed it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Try get a green build for net8.0