[tests] introduce AssertionExtensions.WaitForGC()
#16237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've found the most reliable way to make DeviceTests
run the GC for all platforms is:
Assert.NotNull(pageReference);
await AssertionExtensions.Wait(() =>
{
GC.Collect();
GC.WaitForPendingFinalizers();
return !pageReference.IsAlive;
}, timeout: 5000);
Let's standardize on this, so we can instead do:
await AssertionExtensions.WaitForGC(pageReference);
And if you have multiple:
await AssertionExtensions.WaitForGC(pageReference, handlerReference);
The helper method also checks if the `params WeakReference[]` is empty,
or any `WeakReference` are null. I simplified various tests with this
change.
rmarinho
approved these changes
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found the most reliable way to make DeviceTests run the GC for all platforms is:
Let's standardize on this, so we can instead do:
And if you have multiple:
The helper method also checks if the
params WeakReference[]is empty, or anyWeakReferenceare null. I simplified various tests with this change.