Import Keyboard Extension APIs #16572
Conversation
Eilon
added
the
legacy-area-controls
|
@PureWeen I wrote a simple Appium test for verifying the change. I was wondering how in-depth to go with it since your keyboard PR covers similar ground, and it may make sense to combine the tests onto a single page. |
samhouts
requested review from
a team and
StephaneDelcroix
and removed request for
a team
PureWeen
requested review from
rachelkang
and removed request for
StephaneDelcroix
|
@rachelkang - are you able to review this PR? |
| @@ -60,5 +65,67 @@ public static InputTypes ToInputType(this Keyboard self) | |||
|
|
|||
| return result; | |||
| } | |||
|
|
|||
| internal static bool HideKeyboard(this AView inputView) | |||
There was a problem hiding this comment.
Rename these to match HideSoftInput
| using IPlatformViewHandler = Microsoft.Maui.IViewHandler; | ||
| #endif | ||
|
|
||
| namespace Microsoft.Maui.Platform; |
There was a problem hiding this comment.
Hmmm I'm wondering if we want the extensions against ITextInput to be inside the Microsoft.Maui namespace so they are just by default exposed opposed to needing to pull in Microsoft.Maui.Platform. I realize that create of a naming conflict.
What if for the public facing one we just name it SoftInputExtentions
Co-authored-by: Shane Neuville <shane94@hotmail.com>
src/Controls/src/Core/Platform/Android/Extensions/InputViewExtensions.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/DeviceTests/Elements/Modal/ModalTests.Android.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
|
@drasticactions once this PR is merged that should fix up UITests from failing in CI |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
LGTM! Thanks for incorporating all the feedback!
One thing I've noticed is that your indentations generally look extra space-y - could you review your tabs/spaces, indentations, new lines to make sure they're all as expected?
I have a few other nitpick suggestions and questions I've left comments on, but overall, looks great!
Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
| using IPlatformViewHandler = Microsoft.Maui.IViewHandler; | ||
| #endif | ||
|
|
||
| namespace Microsoft.Maui.Platform; |
There was a problem hiding this comment.
Thoughts on
- Move this extension to
Microsoft.Mauiand up one folder- My concern is requiring folks to import
Microsoft.Maui.Platformto use these APIs
- My concern is requiring folks to import
- move the platform level implementations out to other extension methods for those view types
- FrameworkElementExtentions (windows)
- ViewExtentions (iOS)
- ViewExtentions (Android)
* Import Keyboard Extension APIs * Tizen... * Test * Fix API * API * Fix original tests * Add Soft Input buttons to entry page * Start adding tests * Update test * Update src/Core/src/Platform/KeyboardExtensions.cs Co-authored-by: Shane Neuville <shane94@hotmail.com> * Apply suggestions from code review Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com> * Apply suggestions from code review Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com> * Move namespaces/files * API * Internal Compatibility update * More fixes --------- Co-authored-by: Shane Neuville <shane94@hotmail.com> Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com>
Fixes #11565