-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UITest] Add more logging and restart in setup #16687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
requested changes
Aug 10, 2023
…app for clean run
…ext being null in teardown
a047e7b
to
8cc6511
Compare
rmarinho
reviewed
Aug 11, 2023
PureWeen
reviewed
Aug 11, 2023
Eilon
requested changes
Aug 13, 2023
src/TestUtils/src/TestUtils.Appium.UITests/UITestContextTestBase.cs
Outdated
Show resolved
Hide resolved
src/TestUtils/src/TestUtils.Appium.UITests/UITestContextTestBase.cs
Outdated
Show resolved
Hide resolved
src/TestUtils/src/TestUtils.Appium.UITests/UITestContextTestBase.cs
Outdated
Show resolved
Hide resolved
PureWeen
approved these changes
Aug 15, 2023
Eilon
approved these changes
Aug 15, 2023
rmarinho
pushed a commit
that referenced
this pull request
Aug 19, 2023
* For UITests add logging to test setup failure and attempt to restart app for clean run * Check for null on App * Log a message to the output if we have to retry and handle UITestContext being null in teardown * Add retry to starting the driver for ios * Emit better log messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #16674