[windows] Fixed CarouselView items rendering

[mauroa]

Description of Change

Added ArrangeOverride override and changed MeasureOverride in ItemContentControl to not call the base implementation when the ItemHeight and ItemWidth are already defined.

When the height and width of the items are already defined, it's likely that the base.MeasureOverride (WinUI) call reduces the original size, causing issues like the items in a CarouselView not fitting the container, which causes more items to be displayed at once. This fix makes sure that we always return the max height and width between the measured override and the existing items height and width. Also, adding ArrangeOverride from WinUI base class to control the layout correctly and completely on our side.

CarouselView before the fix:

CarouselView after the fix:

Also added Apium tests to validate that a single item is always shown in the carousel.

• Fixes Carousel View does not behave properly in Windows #12567
• Fixes [Windows] CarouselView Layout is broken #13057
• Fixes CarouselView on Windows totally broken #12850

[samhouts]

I wonder if this will also fix these:

#13057
#12850

[jknaudt21]

This is awesome! Considering that the control was super broken until now, this is a huge improvement. Some minor things to consider though:

• Scrolling through the CarouselView flickers a bit and seems to be more sensitive when scrolling in one direction than the other. In the gif below I change scroll directions and the view began flickering. This was present before this PR so I doubt these changes had an effect.
  
• If I resize my screen, the CarouselView doesn't remain centered/move with the resize. If I resize long enough, I see (and can interact with) the other items in the view. Testing this out before this PR was impossible because the control was broken
  

[mauroa]

I wonder if this will also fix these:

#13057 #12850

It should, however I need to review why it's not working that good when resizing the window, as JD pointed. Once that's resolved, it should fix the three issues (this one and the other two)

[mauroa]

This is awesome! Considering that the control was super broken until now, this is a huge improvement. Some minor things to consider though:

• Scrolling through the CarouselView flickers a bit and seems to be more sensitive when scrolling in one direction than the other. In the gif below I change scroll directions and the view began flickering. This was present before this PR so I doubt these changes had an effect.
  
• If I resize my screen, the CarouselView doesn't remain centered/move with the resize. If I resize long enough, I see (and can interact with) the other items in the view. Testing this out before this PR was impossible because the control was broken
  

@jknaudt21 I fixed the resizing issue, you can see it in the latest commit

[mauroa]

I wonder if this will also fix these:

#13057 #12850

@samhouts I just linked the other bugs too, after addressing JD's feedback

[jknaudt21]

@mauroa I think there are still a couple of rough edges with the resize changes you pushed.

Grey blocks appear when resizing and it doesn't re-center 100% of the time

I might also be nit-picking but it seems that maybe there's a lot of computation going on? The resize felt a bit less responsive.

Sometimes resizing the screen very fast causes the app to crash with an NRE.

This seems to be easier to repro by resizing as soon as the page loads, so it might be that something isn't fully yet initialized? The failure happens in native UWP code, so it's going to be hard to debug 😅. The stack traces lead me to WindowsMessageManager.uwp.cs.

[mauroa]

@mauroa I think there are still a couple of rough edges with the resize changes you pushed.

Grey blocks appear when resizing and it doesn't re-center 100% of the time
Sometimes resizing the screen very fast causes the app to crash with an NRE.

I think we should track this grey item thing when resizing, as a separate issue to investigate. I can reproduce it before my changes and it probably affects other controls as well, it looks like a refreshing issue. Given this PR fixes three bugs and the refreshing issue is pre-existing, I would say we are safe to go and open a separate issue to track the remaining one.

[jknaudt21]

Approving so the fix can go in and then later polish the issue with resizing the screen.

[hartez]

/backport to net7.0

[github-actions]

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/6017941843

[github-actions]

@hartez backporting to net7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: [windows] Added ArrangeOverride override and changed MeasureOverride in ItemContentControl to not call base when the ItemHeight and ItemWidth are defined
Applying: Added Appium test for CarouselView to validate fix for bug #12567
Applying: Fix RS0016 + added inheritdoc
error: sha1 information is lacking or useless (src/Controls/src/Core/Platform/Windows/CollectionView/ItemContentControl.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Fix RS0016 + added inheritdoc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[github-actions]

@hartez an error occurred while backporting to net7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.