-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the control over resource generation #16845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks ok, I mainly had questions about naming.
...SingleProject/Resizetizer/src/nuget/buildTransitive/Microsoft.Maui.Resizetizer.After.targets
Outdated
Show resolved
Hide resolved
...SingleProject/Resizetizer/src/nuget/buildTransitive/Microsoft.Maui.Resizetizer.After.targets
Outdated
Show resolved
Hide resolved
...SingleProject/Resizetizer/src/nuget/buildTransitive/Microsoft.Maui.Resizetizer.After.targets
Outdated
Show resolved
Hide resolved
@@ -568,6 +574,7 @@ | |||
</Target> | |||
|
|||
<Target Name="ResizetizeImages" | |||
Condition="'$(EnableMauiImageProcessing)' != 'false'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other thought, is we generally document every MSBuild property that is public, such as this doc that is synced with MS docs:
Should we prefix all these values with _
to make them private, but useable? Or is there a decent place to document them? Like:
https://github.com/dotnet/maui/blob/main/src/Workload/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I want public, but not sure I am ready to commit.
/rebase |
6724a3e
to
1020c94
Compare
Related: #14421 |
Some black splash screens are a result of xamarin/xamarin-macios#18777 |
Description of Change
Previously, there was an issue where if you deleted the
<MauiSplashScreen>
item and did NOT have a custom splash screen, then the iOS app would render incorrectly:This is not great behavior, so we went and added a way to automatically generate a splash screen for you if we detected that you did not have one:
This made things amazing again, except if you want to have a custom splash screen from a storyboard:
As a result, this PR is partially "reverting" the change because having no way to override the splash screen is worse than having a weird looking app that you will need to fix anyway for the App Store.
This PR has a few things actually:
<EnableMauiAssetProcessing>
can stop the packaging of any<MauiAsset>
items<EnableMauiSplashScreenProcessing>
can stop the packaging of any<MauiSplashScreen>
items<EnableMauiFontProcessing>
can stop the packaging of any<MauiFont>
items<EnableMauiImageProcessing>
can stop the packaging of any<MauiImage>
items<EnableBlankMauiSplashScreen>
will generate a blank splash screen if no<MauiSplashScreen>
items were found. This will override any custom splash screens and may/probably will cause an App Store rejection. But, it is useful in testing to ensure the app UI is correct.Issues Fixed
Fixes #16843