[WinUI] Update shadow mask as part of shadow properties #16895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shadow mask needs to be updaded with the shadow properties, because if the size or shape of the object changed the mask needs to be updated accordingly. This fixes a regression, but brings back another problem: shadows won't work for borders with no content (#13944). The workaround for that scenario is to add content or a background color to the border. Fixes #16094
BretJohnson
previously approved these changes
Aug 21, 2023
mauroa
reviewed
Aug 21, 2023
emaf
force-pushed
the
dev/ema/fix-shadows
branch
from
9369ed8
to
94ff7bd
Compare
mauroa
approved these changes
Aug 21, 2023
PureWeen
requested changes
Aug 21, 2023
akhanalcs
reviewed
Aug 21, 2023
| { | ||
| if (HasShadow) | ||
| UpdateShadow(); | ||
| UpdateShadowAsync().FireAndForget(IPlatformApplication.Current?.Services?.CreateLogger(nameof(WrapperView))); |
There was a problem hiding this comment.
Looks somewhat hard to read. Can this be put on multiple lines?
PureWeen
approved these changes
Aug 22, 2023
|
#16895 (review) isn't a regression caused by this PR |
Open a separte issue for the clipped images problem: #16922 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The shadow mask needs to be updaded with the shadow properties, because if the size or shape of the object changed the mask needs to be updated accordingly.
This fixes a regression, but brings back another problem: shadows won't work for borders with no content (#13944). The workaround for that scenario is to add content or a background color to the border.
Issues Fixed
Fixes #16094