-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[regression/8.0.0-preview.5.8529] - WinUI shadows are broken #16094
Comments
I don't know how better to show what I am building, and the issues I am running so... Inspired by both of your works... All custom using Handlers/Mappers NavigationPage, NavigationBar with CRUD, TabView, SlidingPanel, DialogView, MessageBox, ComboBox, MediaSelection, etc. Complete control and access to colors/fonts/shadows/animations from Maui layer to and including platform layer for the developer! |
Verified this on Visual Studio Enterprise 17.7.0 Preview 6.0. Repro on Windows 11 .NET 8, not repro on Android 13.0-API33 and iOS 16.4 with below Project: |
The shadow mask needs to be updaded with the shadow properties, because if the size or shape of the object changed the mask needs to be updated accordingly. This fixes a regression, but brings back another problem: shadows won't work for borders with no content (#13944). The workaround for that scenario is to add content or a background color to the border. Fixes #16094
The shadow mask needs to be updaded with the shadow properties, because if the size or shape of the object changed the mask needs to be updated accordingly. This fixes a regression, but brings back another problem: shadows won't work for borders with no content (#13944). The workaround for that scenario is to add content or a background color to the border. Fixes #16094
* [WinUI] Update shadow mask as part of shadow properties The shadow mask needs to be updaded with the shadow properties, because if the size or shape of the object changed the mask needs to be updated accordingly. This fixes a regression, but brings back another problem: shadows won't work for borders with no content (#13944). The workaround for that scenario is to add content or a background color to the border. Fixes #16094 * Use FireAndForget instead of async void * Fix spacing issues
Description
Add shadows to standard controls...
![image](https://private-user-images.githubusercontent.com/46286656/252815775-3f598af2-b67b-442c-8947-6f50744b69ba.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5ODk2NTcsIm5iZiI6MTcyNTk4OTM1NywicGF0aCI6Ii80NjI4NjY1Ni8yNTI4MTU3NzUtM2Y1OThhZjItYjY3Yi00NDJjLTg5NDctNmY1MDc0NGI2OWJhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDE3MjkxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdlYWEzODA1NGU1NjNiMTI2MGM1NjdjZGM1ZmEzN2ExN2U1ZTdmZTU1NGUzM2JhNDFlZGExMjU5MThiMjEwMzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iE8j8Nx1pAyaU9t-i7yISwTj7C0pYEFde2hL1lX6dx4)
Steps to Reproduce
Link to public reproduction project repository
n/a - just add shadows to elements
Version with bug
8.0.0-preview.5.8529
Last version that worked well
7.0.86
Affected platforms
Windows
Affected platform versions
Windows SDK - all
Did you find any workaround?
no
Relevant log output
No response
The text was updated successfully, but these errors were encountered: