Remove pinning to NET7 SDK #17035
Merged
Remove pinning to NET7 SDK #17035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The main branch builds find with the NET 8 sdk so there's no reason to require/pin it to NET7
PureWeen
requested review from
StephaneDelcroix,
jfversluis,
Redth,
jonathanpeppers,
mattleibow and
rmarinho
and removed request for
StephaneDelcroix and
jfversluis
rmarinho
approved these changes
Aug 28, 2023
jonathanpeppers
approved these changes
Aug 28, 2023
Comment on lines
-9
to
-12
| "sdk": { | ||
| "version": "7.0.200", | ||
| "allowPrerelease": true, | ||
| "rollForward": "major" |
There was a problem hiding this comment.
Removing these lines is very similar behavior to it being here. rollForward=major allows it to use .NET 8 SDKs.
Either way, seems fine to just delete these as even the .NET team doesn't really suggest using global.json by default -- it's more of something for working around a problem.
There was a problem hiding this comment.
Yea, I was thinking with your edits it should be using .NET8.
But mine was still using .NET 7 when I had these there. I had to delete them in order for VS or the CLI to use .NET8.
mattleibow
approved these changes
Aug 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The main branch builds find with the .NET 8 SDK, so there's no reason to require/pin it to NET7.