Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] Lowest specificity for propagated values #17648

Merged
merged 1 commit into from
Nov 20, 2023
Merged

[C] Lowest specificity for propagated values #17648

merged 1 commit into from
Nov 20, 2023

Conversation

StephaneDelcroix
Copy link
Contributor

@StephaneDelcroix StephaneDelcroix commented Sep 26, 2023 •
edited
Loading

Description of Change

IsEnabled value is propagated on parenting. Do this with the special
(fromHandler) specificity, to allow styling

Issues Fixed

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner September 26, 2023 09:42
@StephaneDelcroix StephaneDelcroix mentioned this pull request Sep 26, 2023
Closed
@samhouts samhouts added this to the .NET 8 GA milestone Oct 5, 2023
@mattleibow
Copy link
Member

/rebase

PureWeen
PureWeen previously requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this PR is targeting main (SR1) with a GA milestone.
Can you please update the Milestone to SR1 or update the targeted branch to net8.0.

@StephaneDelcroix StephaneDelcroix changed the base branch from main to net8.0 October 9, 2023 19:19
@StephaneDelcroix
Copy link
Contributor Author

StephaneDelcroix commented Oct 9, 2023 •
edited
Loading

@PureWeen manually rebased on top of net8 (as the /rebase command messed things up)

@PureWeen
Copy link
Member

PureWeen commented Oct 9, 2023 •
edited
Loading

@StephaneDelcroix it looks like this broke @mattleibow's test code and how InputTransparent propagtes

 at Microsoft.Maui.AppiumTests.InputTransparencyGalleryTests.RunTest(String test, Nullable`1 clickable, Nullable`1 passthru) in /Users/builder/azdo/_work/1/s/src/Controls/tests/UITests/Tests/Concepts/InputTransparencyGalleryTests.cs:line 54
   at Microsoft.Maui.AppiumTests.InputTransparencyGalleryTests.Matrix(Boolean rootTrans, Boolean rootCascade, Boolean nestedTrans, Boolean nestedCascade, Boolean trans) in /Users/builder/azdo/_work/1/s/src/Controls/tests/UITests/Tests/Concepts/InputTransparencyGalleryTests.cs:line 31
   at InvokeStub_InputTransparencyGalleryTests.Matrix(Object, Span`1)

@StephaneDelcroix
Copy link
Contributor Author

some failing tests related to Command and isEnabled

@samhouts samhouts added the s/pr-needs-author-input PR needs an update from the author label Oct 16, 2023
@ghost
Copy link

ghost commented Oct 16, 2023

Hi @StephaneDelcroix. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

@StephaneDelcroix
Copy link
Contributor Author

@samhouts removing the label to avoid auto-closure of the PR. this is still on my plate, and still being worked on

@StephaneDelcroix StephaneDelcroix removed the s/pr-needs-author-input PR needs an update from the author label Oct 17, 2023
@PureWeen PureWeen marked this pull request as draft October 25, 2023 19:12
@PureWeen PureWeen modified the milestones: .NET 8 GA, .NET 8 SR1 Oct 31, 2023
@Eilon Eilon added the area-xaml XAML, CSS, Triggers, Behaviors label Nov 8, 2023
@StephaneDelcroix StephaneDelcroix changed the base branch from net8.0 to main November 13, 2023 13:02
@StephaneDelcroix
[C] Lowest specificity for propagated values
2b7ba19 
IsEnabled value is propagated on parenting. Do this with the special
(fromHandler) specificity, to allow styling

- fixes #17597
@StephaneDelcroix StephaneDelcroix marked this pull request as ready for review November 16, 2023 11:14
@Redth Redth merged commit 2cdf723 into main Nov 20, 2023
47 checks passed
@Redth Redth deleted the fix_17597 branch November 20, 2023 21:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@PureWeen PureWeen PureWeen left review comments

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.6 Look for this fix in 8.0.6 SR1!
Projects
None yet
Milestone
.NET 8 SR1
Development

Successfully merging this pull request may close these issues.

Style Trigger Binding Not Recognizing Default Setter
6 participants
@StephaneDelcroix @mattleibow @PureWeen @Redth @Eilon @samhouts