-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from xamarin/xamarin-android #1798
[main] Update dependencies from xamarin/xamarin-android #1798
Conversation
38a3fc3
to
ecf4808
Compare
The failure is:
I heard about some new MSBuild/Roslyn setting that is now required if you need reference assemblies produced in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, yes this is the break: dotnet/msbuild#6560
So we just need to set $(ProduceReferenceAssemblyInOutDir)
in a Directory.Build.props
somewhere. Note that the code uses a different property than the PR description.
Let me know if something else is broken after this one.
…uild 6.0.1xx-preview7-49aa721f5b320db2a9efabd5707cb0fe1a3a7b4e-1 Microsoft.Android.Sdk.Windows From Version 30.0.100-preview.7.95 -> To Version 30.0.100-preview.7.98 Dependency coherency updates Microsoft.NETCore.App.Ref,Microsoft.Dotnet.Sdk.Internal,Microsoft.Extensions.Primitives,Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.Extensions.FileProviders.Embedded,Microsoft.AspNetCore.Authorization,Microsoft.AspNetCore.Components.WebView,Microsoft.AspNetCore.Components.Web,Microsoft.JSInterop,Microsoft.WindowsDesktop.App.Runtime.win-x64,System.CodeDom From Version 6.0.0-preview.7.21368.2 -> To Version 6.0.0-preview.7.21371.11 (parent: Microsoft.Dotnet.Sdk.Internal
b558576
to
020e2d0
Compare
…uild 6.0.1xx-preview7-89732ff8fdb9d1dcff23a76f7acc87a540d6066f-1 Microsoft.Android.Sdk.Windows From Version 30.0.100-preview.7.95 -> To Version 30.0.100-preview.7.100 Dependency coherency updates Microsoft.NETCore.App.Ref,Microsoft.Dotnet.Sdk.Internal,Microsoft.Extensions.Primitives,Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.Extensions.FileProviders.Embedded,Microsoft.AspNetCore.Authorization,Microsoft.AspNetCore.Components.WebView,Microsoft.AspNetCore.Components.Web,Microsoft.JSInterop,Microsoft.WindowsDesktop.App.Runtime.win-x64,System.CodeDom From Version 6.0.0-preview.7.21368.2 -> To Version 6.0.0-preview.7.21376.17 (parent: Microsoft.Dotnet.Sdk.Internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$(ProduceReferenceAssemblyInOutDir)
seems to have done the trick; it doesn't need to be conditional.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/xamarin/xamarin-android