Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templates] Remove get-task-allow entitlement from Templates #18272

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

dustin-wojciechowski
Copy link
Contributor

Description of Change

@davidbritch brought this to my attention in this issue: #18259 (comment).

Some time ago, the solution was to add this entitlement to a project: #7706 (comment)

There had been some recent developments, and the issue was correctly addressed by #14610 and #16631.

Indeed, to test this, I created a template in NET8 for Blazor Hybrid, removed the entitlement from the entitlements.plist file, and then rebuilt the application and verified I could still use the developer tools.

Being that the entitlement is no longer necessary, we should remove it entirely from the templates.

@dustin-wojciechowski dustin-wojciechowski added area-blazor Blazor Hybrid / Desktop, BlazorWebView area-templates Project templates, Item Templates for Blazor and MAUI Blazor ❤️ MAUI Issues in MAUI functionality that affect Blazor, but are not bugs in Blazor itself labels Oct 23, 2023
@dustin-wojciechowski dustin-wojciechowski marked this pull request as ready for review October 24, 2023 19:02
@PureWeen PureWeen enabled auto-merge (squash) October 24, 2023 19:30
@PureWeen PureWeen merged commit 01d6b39 into net8.0 Oct 24, 2023
45 of 47 checks passed
@PureWeen PureWeen deleted the dev/remove-get-task-allow-entitlement branch October 24, 2023 21:25
@PureWeen
Copy link
Member

/backport to release/8.0.1xx-rc2.2

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-rc2.2: https://github.com/dotnet/maui/actions/runs/6633401496

@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Blazor Hybrid / Desktop, BlazorWebView area-templates Project templates, Item Templates for Blazor and MAUI Blazor ❤️ MAUI Issues in MAUI functionality that affect Blazor, but are not bugs in Blazor itself fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants