Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filename case sensitivity #18561

Merged
merged 3 commits into from Nov 7, 2023

Conversation

moljac
Copy link
Contributor

@moljac moljac commented Nov 7, 2023

Description of Change

Fixing filesystem casing issues in the repo:

Error 1:

dotnet build src/Compatibility/ControlGallery/test/Android.UITests/
CSC : error CS2001: Source file './src/Compatibility/ControlGallery/src/Issues.Shared/Issue3262.cs' could not be found. [./src/Compatibility/ControlGallery/test/Android.UITests/Compatibility.ControlGallery.Android.UITests.csproj]

Issues Fixed

None. Working on some other PRs and unit tests are failing.

@moljac moljac requested a review from a team as a code owner November 7, 2023 09:31
@moljac
Copy link
Contributor Author

moljac commented Nov 7, 2023

Errors:

2023-11-07T10:07:22.1279525Z   Core.DeviceTests.Shared -> D:\a\_work\1\s\src\Core\tests\DeviceTests.Shared\bin\Release\net8.0-windows10.0.19041\Microsoft.Maui.DeviceTests.Shared.dll
2023-11-07T10:07:22.9070391Z D:\a\_work\1\s\bin\dotnet\sdk\8.0.100-rc.2.23502.2\Microsoft.Common.CurrentVersion.targets(4725,5): error MSB3027: Could not copy "obj\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll" to "bin\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll". Exceeded retry count of 10. Failed.  [D:\a\_work\1\s\src\Graphics\src\Text.Markdig\Graphics.Text.Markdig.csproj]

... snip ...

2023-11-07T10:31:38.9228286Z D:\a\_work\1\s\bin\dotnet\sdk\8.0.100-rc.2.23502.2\Microsoft.Common.CurrentVersion.targets(4725,5): error MSB3027: Could not copy "obj\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll" to "bin\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll". Exceeded retry count of 10. Failed.  [D:\a\_work\1\s\src\Graphics\src\Text.Markdig\Graphics.Text.Markdig.csproj]
2023-11-07T10:31:38.9234909Z D:\a\_work\1\s\bin\dotnet\sdk\8.0.100-rc.2.23502.2\Microsoft.Common.CurrentVersion.targets(4725,5): error MSB3021: Unable to copy file "obj\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll" to "bin\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll". The requested operation cannot be performed on a file with a user-mapped section open. : 'D:\a\_work\1\s\src\Graphics\src\Text.Markdig\bin\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll' 

@rmarinho
Copy link
Member

rmarinho commented Nov 7, 2023

Should we rename the file instead?

@rmarinho
Copy link
Member

rmarinho commented Nov 7, 2023

Errors:

2023-11-07T10:07:22.1279525Z   Core.DeviceTests.Shared -> D:\a\_work\1\s\src\Core\tests\DeviceTests.Shared\bin\Release\net8.0-windows10.0.19041\Microsoft.Maui.DeviceTests.Shared.dll
2023-11-07T10:07:22.9070391Z D:\a\_work\1\s\bin\dotnet\sdk\8.0.100-rc.2.23502.2\Microsoft.Common.CurrentVersion.targets(4725,5): error MSB3027: Could not copy "obj\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll" to "bin\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll". Exceeded retry count of 10. Failed.  [D:\a\_work\1\s\src\Graphics\src\Text.Markdig\Graphics.Text.Markdig.csproj]

... snip ...

2023-11-07T10:31:38.9228286Z D:\a\_work\1\s\bin\dotnet\sdk\8.0.100-rc.2.23502.2\Microsoft.Common.CurrentVersion.targets(4725,5): error MSB3027: Could not copy "obj\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll" to "bin\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll". Exceeded retry count of 10. Failed.  [D:\a\_work\1\s\src\Graphics\src\Text.Markdig\Graphics.Text.Markdig.csproj]
2023-11-07T10:31:38.9234909Z D:\a\_work\1\s\bin\dotnet\sdk\8.0.100-rc.2.23502.2\Microsoft.Common.CurrentVersion.targets(4725,5): error MSB3021: Unable to copy file "obj\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll" to "bin\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll". The requested operation cannot be performed on a file with a user-mapped section open. : 'D:\a\_work\1\s\src\Graphics\src\Text.Markdig\bin\Release\netstandard2.0\Microsoft.Maui.Graphics.Text.Markdig.dll' 

This is an issue that we see happening a lot on CI. Retry the build normally fixes it .. But if you find out what causes it , that would be awesome.

@moljac
Copy link
Contributor Author

moljac commented Nov 7, 2023

Should we rename the file instead?

Well, it is up to ypu guys. I went easy way.

@moljac
Copy link
Contributor Author

moljac commented Nov 7, 2023

This is an issue that we see happening a lot on CI. Retry the build normally fixes it .. But if you find out what causes it , that would be awesome.

@rmarinho
I think it is caused by parallel builds. It would be good to make project dependency graph and to deparallelize/serialize-sequentialize it.

Smells like

https://github.com/xamarin/xamarin-android/blob/8928f1168a74f9edad705f4851f3e9252a64f90e/src/r8/r8.csproj#L11-L15

But I am not expert on MsBuild

@mattleibow mattleibow merged commit baa86b2 into main Nov 7, 2023
47 checks passed
@mattleibow mattleibow deleted the dev/moljac/20231106-fix-tests-case-sensitive branch November 7, 2023 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants