Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package downgrade errors by fixing versions causing error and introducing/consolidating variables #18562

Merged

Conversation

moljac
Copy link
Contributor

@moljac moljac commented Nov 7, 2023

Description of Change

Working on other PRs and unit tests fail

dotnet build src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj
./src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj : error NU1605: Warning As Error: Detected package downgrade: xunit from 2.5.1 to 2.4.2. Reference the package directly from the project to select a different version. 
./src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj : error NU1605:  Microsoft.Maui.Compatibility.Core.UnitTests -> Microsoft.Maui.TestUtils -> xunit (>= 2.5.1) 
./src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj : error NU1605:  Microsoft.Maui.Compatibility.Core.UnitTests -> xunit (>= 2.4.2)
  1. fixed (bumped) xunit version
  2. introduced msbuild variables for test dependencies (consolidation kinda)

@moljac moljac requested a review from a team as a code owner November 7, 2023 09:55
@rmarinho rmarinho merged commit 5c94660 into main Nov 8, 2023
47 checks passed
@rmarinho rmarinho deleted the dev/moljac/20231107-fix-tests-nuget-package-downgrade branch November 8, 2023 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants