Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Added methods to set the device orientation from UITests #19100

Merged
merged 1 commit into from Nov 30, 2023

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Nov 29, 2023

Description of Change

We have gaps in our UITests with appium compared to Xamarin.UITest. When carrying legacy test we have certain needs such as rotating device, suspending and resuming apps, etc.
This PR include methods to set the device orientation from UITests.

This changes have been tested with a fake test (just rotating) and with the ScrollView tests.

@jsuarezruiz jsuarezruiz requested a review from a team as a code owner November 29, 2023 10:40
@jsuarezruiz jsuarezruiz requested review from mattleibow, PureWeen and jfversluis and removed request for mattleibow November 29, 2023 10:40
@jsuarezruiz
Copy link
Contributor Author

More context, this is required to port Issue773TestsRotationRelayoutIssue (src\Compatibility\ControlGallery\src\Issues.Shared\Issue773.cs)

/// Changes the device orientation to landscape mode.
/// </summary>
/// <param name="app">Represents the main gateway to interact with an app.</param>
public static void SetOrientationLandscape(this IApp app)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmarinho rmarinho merged commit 18be792 into main Nov 30, 2023
47 checks passed
@rmarinho rmarinho deleted the uitest-setorientation branch November 30, 2023 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants