Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Execute build.ps1 from bash on Mac to avoid STDIO streams hang #19257

Merged
merged 8 commits into from Dec 7, 2023

Conversation

mjbond-msft
Copy link
Contributor

@mjbond-msft mjbond-msft commented Dec 6, 2023

Description of Change

This is to address a reliability issue involving MAUI-DeviceTests. Tests run on Mac sporadically hang then fail (timeout) due to the following error:

The STDIO streams did not close within 10 seconds of the exit event from process '/usr/local/bin/pwsh'. This may indicate a child process inherited the STDIO streams and has not yet exited.

It seems that build.ps1 is getting executed as a powershell subprocess and in turn interfering with the IO stream for the pwsh step. As a mitigation, run build.ps1 under a bash step on Mac. This avoids flakiness and in turn avoids having to rerun failed tests.

@mjbond-msft mjbond-msft requested a review from a team as a code owner December 6, 2023 17:03
mattleibow added a commit that referenced this pull request Dec 6, 2023
@mjbond-msft mjbond-msft self-assigned this Dec 6, 2023
@rmarinho rmarinho merged commit 42bb69e into main Dec 7, 2023
48 checks passed
@rmarinho rmarinho deleted the dev/bond/device-tests.start-process branch December 7, 2023 23:11
PureWeen pushed a commit that referenced this pull request Dec 13, 2023
…19257)

* Use Start-Process to run build.ps1

* Show Start-Process command

* Fix: Comma separator prior to -Script argument

* Dedicated .cake parameter setting for -Script

* Fix: Start-Process: Start 3rd parameter with a quote and not an escaped quote

* Execute build.ps1 under pwsh in bash

* Remove references to Start-Process since that solution did not work

* Execute build.ps1 from bash on Mac only
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants