Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Execute build.ps1 from bash on Mac to avoid STDIO streams hang #19257

Merged
merged 8 commits into from Dec 7, 2023
Merged

[ci] Execute build.ps1 from bash on Mac to avoid STDIO streams hang #19257

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f25b6ba
Use Start-Process to run build.ps1
mjbond-msft Dec 6, 2023
17d0915
Show Start-Process command
mjbond-msft Dec 6, 2023
d2b23db
Fix: Comma separator prior to -Script argument
mjbond-msft Dec 6, 2023
87a9933
Dedicated .cake parameter setting for -Script
mjbond-msft Dec 6, 2023
f45422c
Fix: Start-Process: Start 3rd parameter with a quote and not an escap…
mjbond-msft Dec 6, 2023
3cee048
Execute build.ps1 under pwsh in bash
mjbond-msft Dec 6, 2023
94e5ee3
Remove references to Start-Process since that solution did not work
mjbond-msft Dec 6, 2023
90c1411
Execute build.ps1 from bash on Mac only
mjbond-msft Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 22 additions & 1 deletion eng/pipelines/common/device-tests-steps.yml
View file
Open in desktop
Expand Up @@ -55,9 +55,30 @@ steps:
- pwsh: ./build.ps1 --target=dotnet-buildtasks --configuration="Release"
displayName: 'Build the MSBuild Tasks'

- pwsh: ./build.ps1 -Script eng/devices/${{ parameters.platform }}.cake --project="${{ parameters.path }}" --device=${{ parameters.device }} --packageid=${{ parameters.windowsPackageId }} --results="$(TestResultsDirectory)" --binlog="$(LogDirectory)" ${{ parameters.cakeArgs }}
- pwsh: |
$platformName = 'Windows'
if ($IsMacOS) {
$platformName = 'Mac'
} elseif ($IsLinux) {
$platformName = 'Linux'
}
Write-Host "Platform.Name: ${platformName}"
Write-Host "##vso[task.setvariable variable=Platform.Name]${platformName}"
displayName: 'Set Platform.Name'

- pwsh: |
./build.ps1 -Script eng/devices/${{ parameters.platform }}.cake --project="${{ parameters.path }}" --device=${{ parameters.device }} --packageid=${{ parameters.windowsPackageId }} --results="$(TestResultsDirectory)" --binlog="$(LogDirectory)" ${{ parameters.cakeArgs }}
displayName: $(Agent.JobName)
workingDirectory: ${{ parameters.checkoutDirectory }}
condition: and(succeeded(), ne(variables['Platform.Name'], 'Mac'))
retryCountOnTaskFailure: 2

- bash: |
# Execute the powershell script from a bash shell on Mac to avoid interference between powershell processes that lead to this error: The STDIO streams did not close within 10 seconds of the exit event from process '/usr/local/bin/pwsh'. This may indicate a child process inherited the STDIO streams and has not yet exited.
pwsh ./build.ps1 -Script eng/devices/${{ parameters.platform }}.cake --project="${{ parameters.path }}" --device=${{ parameters.device }} --packageid=${{ parameters.windowsPackageId }} --results="$(TestResultsDirectory)" --binlog="$(LogDirectory)" ${{ parameters.cakeArgs }}
displayName: $(Agent.JobName)
workingDirectory: ${{ parameters.checkoutDirectory }}
condition: and(succeeded(), eq(variables['Platform.Name'], 'Mac'))
retryCountOnTaskFailure: 2

- task: PublishTestResults@2
Expand Down