Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] FlyoutIsPresented property opens the Flyout #19807

Merged
merged 5 commits into from Jan 16, 2024
Merged

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jan 10, 2024

Description of Change

FlyoutIsPresented property opens the Flyout correctly.

fix-8226

Issues Fixed

Fixes #8226

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/android 🤖 area/shell 🐢 Shell Navigation, Routes, Tabs, Flyout labels Jan 10, 2024
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner January 10, 2024 16:14
{
if (child == _flyoutContent?.AndroidView)
// If the AndroidView property which is the DrawerLayout is initialized at this point, the Flyout first draw pass finished.
if (_flyoutContent?.AndroidView is not null)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original condition is only true after opened the Drawer at least once. For this reason, in the issue the comments share that it works if the menu is opened with a gesture or with the hamburger button at least once but not using directly the FlyoutIsPresented property.
The FlyoutFirstDrawPassFinished property prevents opening the Drawer before it is initialized with a property change to avoid incorrect states, but at this point, if the DrawerLayout has been initialized and the contents drawn we should be able to initialize it.

@PureWeen PureWeen enabled auto-merge (squash) January 16, 2024 19:38
@PureWeen PureWeen merged commit abe0025 into main Jan 16, 2024
47 checks passed
@PureWeen PureWeen deleted the fix-8226-II branch January 16, 2024 21:46
@criss02-cs
Copy link

Still not working on Android
https://github.com/criss02-cs/ObsidianUI
here is my repository, just run the project on android and you can see that if you click the button he doesn't work

@MartyIX
Copy link
Collaborator

MartyIX commented Feb 13, 2024

Still not working on Android
https://github.com/criss02-cs/ObsidianUI
here is my repository, just run the project on android and you can see that if you click the button he doesn't work

Please file a new issue. Old issues and old PRs are things of the past and they are not monitored by devs.

@NickA55
Copy link

NickA55 commented Feb 13, 2024

Why file a new issus? The old issue isn't fixed, it would be a duplicate. Just reopen #8226

@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/shell 🐢 Shell Navigation, Routes, Tabs, Flyout platform/android 🤖 t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell.Current.FlyoutIsPresented = true does not toggle the first time on Android
6 participants