New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] FlyoutIsPresented property opens the Flyout #19807
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
src/Controls/tests/DeviceTests/Elements/Shell/ShellFlyoutTests.Android.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
using AndroidX.DrawerLayout.Widget; | ||
using Microsoft.Maui.Controls; | ||
using System.Threading.Tasks; | ||
using Xunit; | ||
|
||
namespace Microsoft.Maui.DeviceTests | ||
{ | ||
[Category(TestCategory.Shell)] | ||
public partial class ShellTests | ||
{ | ||
[Fact(DisplayName = "FlyoutIsPresented=true sets the visible status of the Shell Flyout.")] | ||
public async Task FlyoutIsPresentedOpenDrawer() | ||
{ | ||
await RunShellTest(shell => | ||
{ | ||
shell.FlyoutContent = new VerticalStackLayout() { new Label() { Text = "Flyout Content" } }; | ||
}, | ||
async (shell, handler) => | ||
{ | ||
// 1. Set FlyoutIsPresented=true to make the Shell Flyout visible. | ||
shell.FlyoutIsPresented = true; | ||
|
||
var dl = GetDrawerLayout(handler) as DrawerLayout; | ||
Assert.NotNull(dl); | ||
|
||
await AssertionExtensions.AssertEventually(() => | ||
{ | ||
// 2. Check that the Flyout has size. | ||
var flyoutFrame = GetFlyoutFrame(handler); | ||
return flyoutFrame.Width > 0 && flyoutFrame.Height > 0 && dl.IsOpen; | ||
}); | ||
}); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original condition is only true after opened the Drawer at least once. For this reason, in the issue the comments share that it works if the menu is opened with a gesture or with the hamburger button at least once but not using directly the
FlyoutIsPresented
property.The
FlyoutFirstDrawPassFinished
property prevents opening the Drawer before it is initialized with a property change to avoid incorrect states, but at this point, if the DrawerLayout has been initialized and the contents drawn we should be able to initialize it.