Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed line break mode for buttons #20133
base: main
Are you sure you want to change the base?
Fixed line break mode for buttons #20133
Changes from all commits
baaad20
4795d24
cf8ee1e
413afe9
9bac723
115381b
e576535
f67c73e
d88ae42
c8c805f
3fd078f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kubaflo we have the same logical bug on the vertical constraint, would you mind fixing that too?
This for example impacts while using a portrait image with
AspectFit
put inside a smaller vertical space withVerticalPosition="Start"
: the image will overflow the container (which is wrong).Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albyrock87 do you perhaps have a sample of this issue? I just want to make sure that we get a test in for your issue either in here or in another PR. I will have a look at what you are seeing and try make a repro, but if you have something it will help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattleibow https://github.com/albyrock87/maui-shell-issues/blob/main/MainPage.xaml#L10
Actual
Expected