-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed line break mode for buttons #20133
base: main
Are you sure you want to change the base?
Conversation
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MAUI/Microsoft me, this gentleman and other developers are spending a lot of time for free trying to help you improve the platform and fix bugs. This PR seems ready to be merged or at least reviewed since three weeks ago. I have another PR waiting since October, and many other developers are on the same situation. If MAUI team needs more devs, please tell Microsoft to hire new developers. Now, besides the complains, can we move on with this PR? Thanks. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey , thanks for your help, seems this changes to the LayoutExtensions are causing some unit tests to failing
6a44807
to
91c880f
Compare
@rmarinho I've fixed the tests |
@rmarinho / @albyrock87 / @StephaneDelcroix could you please have a new look at @kubaflo's code? He updated it based on your feedback, and it would really be helpful to have this issue fixed. |
Please reabse as well. The tests are very red and we think we fixed some more tests recently. Hopefully. CI is a bit dodgy. |
9332090
to
ffad8ef
Compare
/rebase |
ffad8ef
to
cf8ee1e
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -45,6 +45,11 @@ public static Rect ComputeFrame(this IView view, Rect bounds) | |||
{ | |||
consumedWidth = Math.Min(bounds.Width, view.MaximumWidth); | |||
} | |||
else if (!IsExplicitSet(view.Width)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kubaflo we have the same logical bug on the vertical constraint, would you mind fixing that too?
This for example impacts while using a portrait image with AspectFit
put inside a smaller vertical space with VerticalPosition="Start"
: the image will overflow the container (which is wrong).
Thanks
// But, if the element is set to fill vertically and it doesn't have an explicitly set height,
// then we want the minimum between its MaximumHeight and the bounds' height
// MaximumHeight is always positive infinity if not defined by the user
if (view.VerticalLayoutAlignment == LayoutAlignment.Fill && !IsExplicitSet(view.Height))
{
consumedHeight = Math.Min(bounds.Height, view.MaximumHeight);
}
// ->
else if (!IsExplicitSet(view.Height))
{
consumedHeight = Math.Min(bounds.Height, view.DesiredSize.Height);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albyrock87 do you perhaps have a sample of this issue? I just want to make sure that we get a test in for your issue either in here or in another PR. I will have a look at what you are seeing and try make a repro, but if you have something it will help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Hopefully I rebased correctly |
Azure Pipelines successfully started running 3 pipeline(s). |
@mattleibow Thanks! |
/azp run |
I had a bad merge there... Hopefully this fixes it. |
Azure Pipelines successfully started running 3 pipeline(s). |
@kubaflo not sure if you say #20133 (comment) |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
I think a separate PR would be better for it |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
3b732e0
to
993ee46
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
Issues Fixed
Fixes #19806
Before:
before.mov
After:
after.mov