NativeAOT: Update NativeAOT integration tests to run with 9.0.1xx-preview1 #20268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
approved these changes
Jan 31, 2024
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
rmarinho
merged commit cbac993
into
dotnet:release/9.0.1xx-preview1
11 of 16 checks passed
rmarinho
added a commit
that referenced
this pull request
Feb 5, 2024
* Update versions * Update Versions.props * Update versions * Update Versions.props * Update Versions.props * Fix ios versions * Update versions of Tizen * Update iOS * Update Version.Details.xml * Update Versions.props * Update versions again * Update sdk * Dont build net8 * Add loging * skip this one and see * [ci] Push artifacts for the sample tests (#20269) * [ci] Always publish the artifacts * remove verbosity * Enable stable branding * NativeAOT: Update NativeAOT integration tests to run with 9.0.1xx-preview1 (#20268) * Align expected NativeAOT build warning messages in integration tests * Do not treat NativeAOT build warnings as errors - introduced with dotnet/runtime#96567 * [release/9.0.1xx-preview1] Update versions (#20279) * Update versions * Ignore blazor tests on old webview * [release/9.0.1xx-preview1] Revert "Dont build net8" (#20286) * Revert "Dont build net8" This reverts commit 4d59c64. * Update versions * Update Compatibility.csproj * Update versions * Update dotnet.cake Update dotnet.cake Set env variables before build device tests Update DotnetInternal.cs Update dotnet.cake * Don't build template tests again --------- Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Ivan Povazan <55002338+ivanpovazan@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two issues around NativeAOT integration tests:
TreatWarningsAsErrors=trueWith .NET9-p1 NativeAOT integration tests started failing due to dotnet/runtime#96567
This change enabled ILC (NativeAOT compiler) to take
TreatWarningsAsErrorsinto account during compilation.Since this flag is set to
truein integration testing, it caused CI failures.As we are in the process of reducing the number of warnings to 0, until we reach that point we need to run these tests by escaping
TreatWarningsAsErrors=truesetting. This can be achieved by settingIlcTreatWarningsAsErrors=false.<Module>..cctor(): Using member 'System.Enum.GetValues(Type)'warningThis PR fixes both of these issues.
/cc: @simonrozsival