Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx-preview1] Revert "Dont build net8" #20286

Merged
merged 6 commits into from Feb 2, 2024

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Feb 1, 2024

This reverts commit 4d59c64.

Description of Change

Now with sdk fixed we should be able to build net8 with preview1

This reverts commit 4d59c64.
@rmarinho rmarinho requested a review from a team as a code owner February 1, 2024 12:13
@rmarinho rmarinho requested review from StephaneDelcroix and tj-devel709 and removed request for a team February 1, 2024 12:13
@samhouts samhouts added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Feb 2, 2024
Update dotnet.cake

Set env variables before build  device tests

Update DotnetInternal.cs

Update dotnet.cake
@rmarinho rmarinho enabled auto-merge (squash) February 2, 2024 15:22
@rmarinho rmarinho merged commit 055618c into release/9.0.1xx-preview1 Feb 2, 2024
6 checks passed
@rmarinho rmarinho deleted the bring-net8-back branch February 2, 2024 19:02
rmarinho added a commit that referenced this pull request Feb 5, 2024
* Update versions

* Update Versions.props

* Update versions

* Update Versions.props

* Update Versions.props

* Fix ios versions

* Update versions of Tizen

* Update iOS

* Update Version.Details.xml

* Update Versions.props

* Update versions again

* Update sdk

* Dont build net8

* Add loging

* skip this one and see

* [ci] Push artifacts for the sample tests (#20269)

* [ci] Always publish the artifacts

* remove verbosity

* Enable stable branding

* NativeAOT: Update NativeAOT integration tests to run with 9.0.1xx-preview1 (#20268)

* Align expected NativeAOT build warning messages in integration tests

* Do not treat NativeAOT build warnings as errors - introduced with dotnet/runtime#96567

* [release/9.0.1xx-preview1] Update versions (#20279)

* Update versions

* Ignore blazor tests on old webview

* [release/9.0.1xx-preview1]  Revert "Dont build net8" (#20286)

* Revert "Dont build net8"

This reverts commit 4d59c64.

* Update versions

* Update Compatibility.csproj

* Update versions

* Update dotnet.cake

Update dotnet.cake

Set env variables before build  device tests

Update DotnetInternal.cs

Update dotnet.cake

* Don't build template tests again

---------

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Co-authored-by: Ivan Povazan <55002338+ivanpovazan@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants