Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore iOS/macOS SecureStorage.DefaultAccessible default value #20914

Merged
merged 1 commit into from Feb 29, 2024

Conversation

jfversluis
Copy link
Member

Description of Change

Restores the default value of SecureStorage.DefaultAccessible for iOS & macOS. In #4668 this default value was dropped, but I don't see indication this was intentional. To make migration from Xamarin.Forms easier this should still be the same(?) although at this point this might be a breaking change for .NET MAUI 🤷‍♂️

So if we decide to not do this change we need to update the documentation.

Issues Fixed

Fixes #17582

@jfversluis jfversluis added area/essentials 🍞 Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert labels Feb 29, 2024
@jfversluis jfversluis requested a review from a team as a code owner February 29, 2024 12:19
@rmarinho rmarinho merged commit 2ddd28a into main Feb 29, 2024
43 of 47 checks passed
@rmarinho rmarinho deleted the fix-17582 branch February 29, 2024 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/essentials 🍞 Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultAccessible seems to have the wrong default value
2 participants