Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XmlType .Equals override #21192

Merged
merged 1 commit into from Mar 15, 2024
Merged

Fix XmlType .Equals override #21192

merged 1 commit into from Mar 15, 2024

Conversation

mgoertz-msft
Copy link
Contributor

@mgoertz-msft mgoertz-msft commented Mar 13, 2024 •
edited

  • Make sure to only check type argument sequences if both of them are non-null
  • Add XmlType equality tests for this and other equality scenarios

Fixes #21170

@mgoertz-msft mgoertz-msft requested a review from a team as a code owner March 13, 2024 21:44
@mgoertz-msft mgoertz-msft mentioned this pull request Mar 13, 2024
Closed
@mgoertz-msft mgoertz-msft changed the title - Make sure to only check type argument sequences if both of them are non-null - Add XmlType equality tests for this and other equality scenarios Fix XmlType .Equals override Mar 13, 2024
@jsuarezruiz jsuarezruiz added the area-xaml XAML, CSS, Triggers, Behaviors label Mar 14, 2024
@mgoertz-msft @PureWeen
- Make sure to only check type argument sequences if both of them are…
7d4048b 
… non-null

- Add XmlType equality tests for this and other equality scenarios
@PureWeen PureWeen changed the base branch from main to release/8.0.1xx-sr3 March 14, 2024 16:37
@PureWeen PureWeen requested review from jonathanpeppers and removed request for jfversluis March 14, 2024 16:37
jonathanpeppers
jonathanpeppers approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgoertz-msft do you know what pattern in XAML code causes the problem here?

Just wondering if there is a workaround, or if we should ship this ASAP.

@mgoertz-msft
Copy link
Contributor Author

@jonathanpeppers Since it tripped over type arguments I would say it would involve generics. Whoever has/needs them is going to be blocked by this.

@rmarinho rmarinho disabled auto-merge March 15, 2024 12:45
@rmarinho rmarinho merged commit ec2f89c into release/8.0.1xx-sr3 Mar 15, 2024
9 of 12 checks passed
@rmarinho rmarinho deleted the de/mgoertz/xmltype branch March 15, 2024 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.NET 8.0.10 breaks MAUI builds
5 participants
@mgoertz-msft @StephaneDelcroix @jonathanpeppers @rmarinho @jsuarezruiz