Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XmlType .Equals override #21192

Merged
merged 1 commit into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Controls/src/Xaml/XamlNode.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ public override bool Equals(object obj)
return
NamespaceUri == other.NamespaceUri &&
Name == other.Name &&
(TypeArguments == null && other.TypeArguments == null || TypeArguments.SequenceEqual(other.TypeArguments));
(TypeArguments == null && other.TypeArguments == null ||
TypeArguments != null && other.TypeArguments != null && TypeArguments.SequenceEqual(other.TypeArguments));
}

public override int GetHashCode()
Expand Down
98 changes: 98 additions & 0 deletions src/Controls/tests/Xaml.UnitTests/XmlTypeTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
using NUnit.Framework;

namespace Microsoft.Maui.Controls.Xaml.UnitTests
{
[TestFixture]
public class XmlTypeTests : BaseTestFixture
{
[Test]
public void TestXmlTypeEquality()
{
// Arrange
var type1 = new XmlType("http://example.com", "Type1", typeArguments: null);
var type2 = new XmlType("http://example.com", "Type1", typeArguments: null);

// Act
var result = type1.Equals(type2);

// Assert
Assert.IsTrue(result);
}

[Test]
public void TestXmlTypeInequality()
{
// Arrange
var type1 = new XmlType("http://example.com", "Type1", typeArguments: null);
var type2 = new XmlType("http://example.com", "Type2", typeArguments: null);

// Act
var result = type1.Equals(type2);

// Assert
Assert.IsFalse(result);
}

[Test]
public void TestXmlTypeEqualityWithTypeArgs()
{
// Arrange
var typeArg = new XmlType("http://example.com", "TypeArg", typeArguments: null);
var type1 = new XmlType("http://example.com", "Type1", typeArguments: [typeArg]);
var type2 = new XmlType("http://example.com", "Type1", typeArguments: [typeArg]);

// Act
var result = type1.Equals(type2);

// Assert
Assert.IsTrue(result);
}

[Test]
public void TestXmlTypeInequalityWithSameTypeArgs()
{
// Arrange
var typeArg = new XmlType("http://example.com", "TypeArg", typeArguments: null);
var type1 = new XmlType("http://example.com", "Type1", typeArguments: [typeArg]);
var type2 = new XmlType("http://example.com", "Type2", typeArguments: [typeArg]);

// Act
var result = type1.Equals(type2);

// Assert
Assert.IsFalse(result);
}


[Test]
public void TestXmlTypeInequalityWithDifferentTypeArgs()
{
// Arrange
var typeArg1 = new XmlType("http://example.com", "TypeArg1", typeArguments: null);
var typeArg2 = new XmlType("http://example.com", "TypeArg2", typeArguments: null);
var type1 = new XmlType("http://example.com", "Type1", typeArguments: [typeArg1]);
var type2 = new XmlType("http://example.com", "Type1", typeArguments: [typeArg2]);

// Act
var result = type1.Equals(type2);

// Assert
Assert.IsFalse(result);
}

[Test]
public void TestXmlTypeInequalityWithAndWithoutTypeArgs()
{
// Arrange
var typeArg = new XmlType("http://example.com", "TypeArg", typeArguments: null);
var type1 = new XmlType("http://example.com", "Type1", typeArguments: [typeArg]);
var type2 = new XmlType("http://example.com", "Type1", typeArguments: null);

// Act
var result = type1.Equals(type2);

// Assert
Assert.IsFalse(result);
}
}
}