Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix if statement check used to null out handler #2128

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Fix if statement check used to null out handler #2128

merged 2 commits into from
Aug 17, 2021

Conversation

PureWeen
Copy link
Member

Description of Change

The logic to null out the handler on a VirtualView when moving a handler to a new VirtualView is incorrect

@PureWeen PureWeen changed the title Fix if statement check used to null out handler [WiP] Fix if statement check used to null out handler Aug 16, 2021
@PureWeen PureWeen changed the title [WiP] Fix if statement check used to null out handler Fix if statement check used to null out handler Aug 17, 2021
@PureWeen PureWeen force-pushed the fix_if_check_for_nulling_handler branch from 6b1936d to 5cb9928 Compare August 17, 2021 00:55
@PureWeen PureWeen merged commit b21cfb0 into main Aug 17, 2021
@PureWeen PureWeen deleted the fix_if_check_for_nulling_handler branch August 17, 2021 02:06
@samhouts samhouts added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@samhouts samhouts added the fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7! legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PureWeen @Redth @mattleibow @samhouts