Set Shell Foreground to original color distinction #21286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @sigged! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
PureWeen
reviewed
Mar 18, 2024
| @@ -399,7 +399,7 @@ | |||
|
|
|||
| <Style TargetType="Shell" ApplyToDerivedTypes="True"> | |||
| <Setter Property="Shell.BackgroundColor" Value="{AppThemeBinding Light={StaticResource White}, Dark={StaticResource OffBlack}}" /> | |||
| <Setter Property="Shell.ForegroundColor" Value="{AppThemeBinding Light={StaticResource Black}, Dark={StaticResource SecondaryDarkText}}" /> | |||
| <Setter Property="Shell.ForegroundColor" Value="{AppThemeBinding Light={StaticResource Primary}, Dark={StaticResource SecondaryDarkText}}" /> | |||
There was a problem hiding this comment.
@davidortinau @rachelkang thoughts?
jsuarezruiz
requested review from
davidortinau and
rachelkang
and removed request for
StephaneDelcroix
jsuarezruiz
added
the
area-templates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As of #18379, the maui-mobile template had a change which causes indistinct colors between the Shell Foreground and Background, causing the default hamburger icon to be invisible, yet usable. This visual bug is due to the OnPlatform setting the Shell Foreground to White, except on WinUI.
This change proposes to drop the OnPlatform exclusivity for WinUI, and revert to the standard AppThemeBinding, which will clearly display the flyout icon, regardless of the dark/light mode on all platforms.
Issues Fixed
Fixes #19178