[Android] Fix CarouselView behavior with device orientation changes #21635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix CarouselView behavior with device orientation changes.
Currently, by changing the orientation we are:
Actually, when changing the orientation, none of the above is necessary besides being left with an incorrect Layout, usually between two elements.
For example, the CurrentItem is 3 and rotating the device:
With the changes we avoid to update position etc rotating the device, and check if need to center the current item. If necessary, scroll adjustment is made.
Issues Fixed
Fixes #21609
Fixes #21401